build: add --debug-symbols to build with -g without enabling DCHECKs · nodejs/node@4fe705f · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 4fe705f

Browse filesBrowse the repository at this point in the historyBrowse files

joyeecheung

authored and

juanarbol

committed

build: add --debug-symbols to build with -g without enabling DCHECKs

This is useful when debugging release builds on Linux without enabling DCHECKs. PR-URL: #61100 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

1 parent c471c12 commit 4fe705f
Copy full SHA for 4fe705f

1 file changed

+9Lines changed: 9 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• configure.py

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎configure.py‎

Copy file name to clipboardExpand all lines: configure.py

+9Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -107,6 +107,12 @@
107	107	default=None,
108	108	help='build the Node.js part of the binary with debugging symbols')
109	109
	110	+ parser.add_argument('--debug-symbols',
	111	+ action='store_true',
	112	+ dest='debug_symbols',
	113	+ default=None,
	114	+ help='add debugging symbols to release builds (adds -g without enabling DCHECKs)')
	115	+
110	116	parser.add_argument('--dest-cpu',
111	117	action='store',
112	118	dest='dest_cpu',
@@ -1457,6 +1463,9 @@ def configure_node(o):
1457	1463	o['variables']['control_flow_guard'] = b(options.enable_cfg)
1458	1464	o['variables']['node_use_amaro'] = b(not options.without_amaro)
1459	1465	o['variables']['debug_node'] = b(options.debug_node)
	1466	+ o['variables']['debug_symbols'] = b(options.debug_symbols)
	1467	+ if options.debug_symbols:
	1468	+ o['cflags'] += ['-g']
1460	1469	o['default_configuration'] = 'Debug' if options.debug else 'Release'
1461	1470	if options.error_on_warn and options.suppress_all_error_on_warn:
1462	1471	raise Exception('--error_on_warn is incompatible with --suppress_all_error_on_warn.')

0 commit comments

Comments

0 (0)