Commit 500f3cc
src: lock the thread properly in snapshot builder
Otherwise it can crash DCHECK when V8 expects that at least someone
is locking the current thread.
PR-URL: #56327
Fixes: nodejs/node-v8#294
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>1 parent 589d0ae commit 500f3cc
1 file changed
Lines changed: 2 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -982,6 +982,8 @@ ExitCode BuildSnapshotWithoutCodeCache( | |||
| 982 | 982 | } | |
| 983 | 983 | ||
| 984 | 984 | Isolate* isolate = setup->isolate(); | |
| 985 | + v8::Locker locker(isolate); | ||
| 986 | + | ||
| 985 | 987 | { | |
| 986 | 988 | HandleScope scope(isolate); | |
| 987 | 989 | TryCatch bootstrapCatch(isolate); | |
0 commit comments