net: increase network family autoselection timeout to 500ms · nodejs/node@506b79e · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 748
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 506b79e

Browse filesBrowse the repository at this point in the historyBrowse files

rvagg

authored and

aduh95

committed

net: increase network family autoselection timeout to 500ms

The current 250ms timeout is too short for high-latency network environments, causing connection failures in IPv4-only networks when connecting to dual-stack hosts. This increases the timeout to 500ms to better handle satellite, cellular, and geographically distant connections. The timeout should be reconsidered when parallel connections are implemented as per RFC 8305. Refs: #54359 Refs: #48145 PR-URL: #60334 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Tim Perry <pimterry@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

1 parent ae91a6c commit 506b79e
Copy full SHA for 506b79e

4 files changed

+6-5Lines changed: 6 additions & 5 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• doc/api
  • net.md
• src
  • node_options.h
• test
  • common
    • index.js
  • parallel
    • test-net-autoselectfamily-attempt-timeout-cli-option.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎doc/api/net.md‎

Copy file name to clipboardExpand all lines: doc/api/net.md

+1-1Lines changed: 1 addition & 1 deletion

• Display the source diff
• Display the rich diff

Original file line number	Diff line number	Diff line change
@@ -1905,7 +1905,7 @@ added:
1905	1905	-->
1906	1906
1907	1907	Gets the current default value of the `autoSelectFamilyAttemptTimeout` option of [`socket.connect(options)`][].
1908		- The initial default value is `250` or the value specified via the command line
	1908	+ The initial default value is `500` or the value specified via the command line
1909	1909	option `--network-family-autoselection-attempt-timeout`.
1910	1910
1911	1911	* Returns: {number} The current default value of the `autoSelectFamilyAttemptTimeout` option.

Collapse file

‎src/node_options.h‎

Copy file name to clipboardExpand all lines: src/node_options.h

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -155,7 +155,7 @@ class EnvironmentOptions : public Options {
155	155	int64_t heap_snapshot_near_heap_limit = 0;
156	156	std::string heap_snapshot_signal;
157	157	bool network_family_autoselection = true;
158		- uint64_t network_family_autoselection_attempt_timeout = 250;
	158	+ uint64_t network_family_autoselection_attempt_timeout = 500;
159	159	uint64_t max_http_header_size = 16 * 1024;
160	160	bool deprecation = true;
161	161	bool force_async_hooks_checks = true;

Collapse file

‎test/common/index.js‎

Copy file name to clipboardExpand all lines: test/common/index.js

+3-2Lines changed: 3 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -184,8 +184,9 @@ function isPi() {
184	184	}
185	185	}
186	186
187		- // When using high concurrency or in the CI we need much more time for each connection attempt
188		- net.setDefaultAutoSelectFamilyAttemptTimeout(platformTimeout(net.getDefaultAutoSelectFamilyAttemptTimeout() * 10));
	187	+ // When using high concurrency or in the CI we need much more time for each connection attempt.
	188	+ // Default 500ms becomes 2500ms for tests.
	189	+ net.setDefaultAutoSelectFamilyAttemptTimeout(platformTimeout(net.getDefaultAutoSelectFamilyAttemptTimeout() * 5));
189	190	const defaultAutoSelectFamilyAttemptTimeout = net.getDefaultAutoSelectFamilyAttemptTimeout();
190	191
191	192	const buildType = process.config.target_defaults ?

Collapse file

‎test/parallel/test-net-autoselectfamily-attempt-timeout-cli-option.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-net-autoselectfamily-attempt-timeout-cli-option.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -7,4 +7,4 @@ const { platformTimeout } = require('../common');
7	7	const assert = require('assert');
8	8	const { getDefaultAutoSelectFamilyAttemptTimeout } = require('net');
9	9
10		- assert.strictEqual(getDefaultAutoSelectFamilyAttemptTimeout(), platformTimeout(123 * 10));
	10	+ assert.strictEqual(getDefaultAutoSelectFamilyAttemptTimeout(), platformTimeout(123 * 5));

0 commit comments

Comments

0 (0)