Commit 50c0a15
build: set v8_enable_webassembly=false when lite mode is enabled
We should set v8_enable_webassembly=false when lite mode is enabled,
since v8_enable_lite_mode implies v8_jitless, and wasm currently
doesn't work with jitless. This is automatically handled in gn, but
seems to be not the case in gyp. Enabling lite mode without setting
v8_enable_webassembly=false leads to "Warning: disabling flag
--expose_wasm due to conflicting flags" at runtime.
PR-URL: #48248
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>1 parent 4562805 commit 50c0a15
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1471,7 +1471,7 @@ def configure_library(lib, output, pkgname=None): | |||
| 1471 | 1471 | ||
| 1472 | 1472 | ||
| 1473 | 1473 | def configure_v8(o): | |
| 1474 | - o['variables']['v8_enable_webassembly'] = 1 | ||
| 1474 | + o['variables']['v8_enable_webassembly'] = 0 if options.v8_lite_mode else 1 | ||
| 1475 | 1475 | o['variables']['v8_enable_javascript_promise_hooks'] = 1 | |
| 1476 | 1476 | o['variables']['v8_enable_lite_mode'] = 1 if options.v8_lite_mode else 0 | |
| 1477 | 1477 | o['variables']['v8_enable_gdbjit'] = 1 if options.gdb else 0 | |
0 commit comments