Commit 5129b7c
tools: fix small not-quite-a-bug in find-inactive-tsc.mjs
The current code attempts to count votes from people who were not
members at the start of the 3 month period, resulting in `NaN` being
tallied for their votes.
PR-URL: #41469
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Tierney Cyren <hello@bnb.im>1 parent 7ac126b commit 5129b7c
1 file changed
Lines changed: 3 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -118,7 +118,9 @@ async function getVotingRecords(tscMembers, votes) { | |||
| 118 | 118 | await fs.promises.readFile(path.join('.tmp', vote), 'utf8') | |
| 119 | 119 | ); | |
| 120 | 120 | for (const member in voteData.votes) { | |
| 121 | - votingRecords[member]++; | ||
| 121 | + if (tscMembers.includes(member)) { | ||
| 122 | + votingRecords[member]++; | ||
| 123 | + } | ||
| 122 | 124 | } | |
| 123 | 125 | } | |
| 124 | 126 | return votingRecords; | |
0 commit comments