| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
1 parent 3df0570 commit 5155d8e
14 files changed
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -586,7 +586,7 @@ testAssertionMessage({ a: undefined, b: null }, '{ a: undefined, b: null }'); | |||
| 586 | 586 | testAssertionMessage({ a: NaN, b: Infinity, c: -Infinity }, | |
| 587 | 587 | '{ a: NaN, b: Infinity, c: -Infinity }'); | |
| 588 | 588 | ||
| 589 | - // #2893 | ||
| 589 | + // https://github.com/nodejs/node-v0.x-archive/issues/2893 | ||
| 590 | 590 | { | |
| 591 | 591 | let threw = false; | |
| 592 | 592 | try { | |
@@ -601,7 +601,7 @@ testAssertionMessage({ a: NaN, b: Infinity, c: -Infinity }, | |||
| 601 | 601 | assert.ok(threw); | |
| 602 | 602 | } | |
| 603 | 603 | ||
| 604 | - // #5292 | ||
| 604 | + // https://github.com/nodejs/node-v0.x-archive/issues/5292 | ||
| 605 | 605 | try { | |
| 606 | 606 | assert.strictEqual(1, 2); | |
| 607 | 607 | } catch (e) { | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -636,7 +636,8 @@ assert.strictEqual('<Buffer 81 a3 66 6f 6f a3 62 61 72>', x.inspect()); | |||
| 636 | 636 | } | |
| 637 | 637 | ||
| 638 | 638 | { | |
| 639 | - // #1210 Test UTF-8 string includes null character | ||
| 639 | + // https://github.com/nodejs/node-v0.x-archive/pull/1210 | ||
| 640 | + // Test UTF-8 string includes null character | ||
| 640 | 641 | let buf = Buffer.from('\0'); | |
| 641 | 642 | assert.strictEqual(buf.length, 1); | |
| 642 | 643 | buf = Buffer.from('\0\0'); | |
@@ -660,7 +661,8 @@ assert.strictEqual('<Buffer 81 a3 66 6f 6f a3 62 61 72>', x.inspect()); | |||
| 660 | 661 | } | |
| 661 | 662 | ||
| 662 | 663 | { | |
| 663 | - // #243 Test write() with maxLength | ||
| 664 | + // https://github.com/nodejs/node-v0.x-archive/issues/243 | ||
| 665 | + // Test write() with maxLength | ||
| 664 | 666 | const buf = Buffer.allocUnsafe(4); | |
| 665 | 667 | buf.fill(0xFF); | |
| 666 | 668 | assert.strictEqual(buf.write('abcd', 1, 2, 'utf8'), 2); | |
@@ -886,12 +888,14 @@ assert.throws(() => Buffer.allocUnsafe(8).writeFloatLE(0.0, -1), RangeError); | |||
| 886 | 888 | assert.strictEqual(buf.readIntBE(0, 5), -0x0012000000); | |
| 887 | 889 | } | |
| 888 | 890 | ||
| 889 | - // Regression test for #5482: should throw but not assert in C++ land. | ||
| 891 | + // Regression test for https://github.com/nodejs/node-v0.x-archive/issues/5482: | ||
| 892 | + // should throw but not assert in C++ land. | ||
| 890 | 893 | assert.throws(() => Buffer.from('', 'buffer'), | |
| 891 | 894 | /^TypeError: "encoding" must be a valid string encoding$/); | |
| 892 | 895 | ||
| 893 | - // Regression test for #6111. Constructing a buffer from another buffer | ||
| 894 | - // should a) work, and b) not corrupt the source buffer. | ||
| 896 | + // Regression test for https://github.com/nodejs/node-v0.x-archive/issues/6111. | ||
| 897 | + // Constructing a buffer from another buffer should a) work, and b) not corrupt | ||
| 898 | + // the source buffer. | ||
| 895 | 899 | { | |
| 896 | 900 | const a = [...Array(128).keys()]; // [0, 1, 2, 3, ... 126, 127] | |
| 897 | 901 | const b = Buffer.from(a); | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -42,7 +42,7 @@ if (cluster.isMaster) { | |||
| 42 | 42 | worker.send(msg); | |
| 43 | 43 | }); | |
| 44 | 44 | } else { | |
| 45 | - // GH #7998 | ||
| 45 | + // https://github.com/nodejs/node-v0.x-archive/issues/7998 | ||
| 46 | 46 | cluster.worker.on('message', (message) => { | |
| 47 | 47 | process.send(message === msg); | |
| 48 | 48 | }); | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -411,7 +411,8 @@ fileStream.on('close', common.mustCall(function() { | |||
| 411 | 411 | ); | |
| 412 | 412 | })); | |
| 413 | 413 | ||
| 414 | - // Issue #2227: unknown digest method should throw an error. | ||
| 414 | + // Unknown digest method should throw an error: | ||
| 415 | + // https://github.com/nodejs/node-v0.x-archive/issues/2227 | ||
| 415 | 416 | assert.throws(function() { | |
| 416 | 417 | crypto.createHash('xyzzy'); | |
| 417 | 418 | }, /^Error: Digest method not supported$/); | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -70,15 +70,16 @@ testCipher1(Buffer.from('MySecretKey123')); | |||
| 70 | 70 | testCipher2('0123456789abcdef'); | |
| 71 | 71 | testCipher2(Buffer.from('0123456789abcdef')); | |
| 72 | 72 | ||
| 73 | - // Base64 padding regression test, see #4837. | ||
| 73 | + // Base64 padding regression test, see | ||
| 74 | + // https://github.com/nodejs/node-v0.x-archive/issues/4837. | ||
| 74 | 75 | { | |
| 75 | 76 | const c = crypto.createCipher('aes-256-cbc', 'secret'); | |
| 76 | 77 | const s = c.update('test', 'utf8', 'base64') + c.final('base64'); | |
| 77 | 78 | assert.strictEqual(s, '375oxUQCIocvxmC5At+rvA=='); | |
| 78 | 79 | } | |
| 79 | 80 | ||
| 80 | 81 | // Calling Cipher.final() or Decipher.final() twice should error but | |
| 81 | - // not assert. See #4886. | ||
| 82 | + // not assert. See https://github.com/nodejs/node-v0.x-archive/issues/4886. | ||
| 82 | 83 | { | |
| 83 | 84 | const c = crypto.createCipher('aes-256-cbc', 'secret'); | |
| 84 | 85 | try { c.final('xxx'); } catch (e) { /* Ignore. */ } | |
@@ -90,14 +91,16 @@ testCipher2(Buffer.from('0123456789abcdef')); | |||
| 90 | 91 | try { d.final('xxx'); } catch (e) { /* Ignore. */ } | |
| 91 | 92 | } | |
| 92 | 93 | ||
| 93 | - // Regression test for #5482: string to Cipher#update() should not assert. | ||
| 94 | + // Regression test for https://github.com/nodejs/node-v0.x-archive/issues/5482: | ||
| 95 | + // string to Cipher#update() should not assert. | ||
| 94 | 96 | { | |
| 95 | 97 | const c = crypto.createCipher('aes192', '0123456789abcdef'); | |
| 96 | 98 | c.update('update'); | |
| 97 | 99 | c.final(); | |
| 98 | 100 | } | |
| 99 | 101 | ||
| 100 | - // #5655 regression tests, 'utf-8' and 'utf8' are identical. | ||
| 102 | + // https://github.com/nodejs/node-v0.x-archive/issues/5655 regression tests, | ||
| 103 | + // 'utf-8' and 'utf8' are identical. | ||
| 101 | 104 | { | |
| 102 | 105 | let c = crypto.createCipher('aes192', '0123456789abcdef'); | |
| 103 | 106 | c.update('update', ''); // Defaults to "utf8". | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -105,7 +105,8 @@ fileStream.on('close', common.mustCall(function() { | |||
| 105 | 105 | 'Test SHA1 of sample.png'); | |
| 106 | 106 | })); | |
| 107 | 107 | ||
| 108 | - // Issue #2227: unknown digest method should throw an error. | ||
| 108 | + // Issue https://github.com/nodejs/node-v0.x-archive/issues/2227: unknown digest | ||
| 109 | + // method should throw an error. | ||
| 109 | 110 | assert.throws(function() { | |
| 110 | 111 | crypto.createHash('xyzzy'); | |
| 111 | 112 | }, /Digest method not supported/); | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -260,8 +260,9 @@ const expectedErrorRegexp = /^TypeError: size must be a number >= 0$/; | |||
| 260 | 260 | } | |
| 261 | 261 | } | |
| 262 | 262 | ||
| 263 | - // #5126, "FATAL ERROR: v8::Object::SetIndexedPropertiesToExternalArrayData() | ||
| 264 | - // length exceeds max acceptable value" | ||
| 263 | + // https://github.com/nodejs/node-v0.x-archive/issues/5126, | ||
| 264 | + // "FATAL ERROR: v8::Object::SetIndexedPropertiesToExternalArrayData() length | ||
| 265 | + // exceeds max acceptable value" | ||
| 265 | 266 | assert.throws(function() { | |
| 266 | 267 | crypto.randomBytes((-1 >>> 0) + 1); | |
| 267 | 268 | }, /^TypeError: size must be a number >= 0$/); | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -159,8 +159,8 @@ testImmutability(tls.getCiphers); | |||
| 159 | 159 | testImmutability(crypto.getHashes); | |
| 160 | 160 | testImmutability(crypto.getCurves); | |
| 161 | 161 | ||
| 162 | - // Regression tests for #5725: hex input that's not a power of two should | ||
| 163 | - // throw, not assert in C++ land. | ||
| 162 | + // Regression tests for https://github.com/nodejs/node-v0.x-archive/pull/5725: | ||
| 163 | + // hex input that's not a power of two should throw, not assert in C++ land. | ||
| 164 | 164 | assert.throws(function() { | |
| 165 | 165 | crypto.createCipher('aes192', 'test').update('0', 'hex'); | |
| 166 | 166 | }, (err) => { | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -23,7 +23,7 @@ | |||
| 23 | 23 | const common = require('../common'); | |
| 24 | 24 | const dgram = require('dgram'); | |
| 25 | 25 | ||
| 26 | - // should not hang, see #1282 | ||
| 26 | + // should not hang, see https://github.com/nodejs/node-v0.x-archive/issues/1282 | ||
| 27 | 27 | dgram.createSocket('udp4'); | |
| 28 | 28 | dgram.createSocket('udp6'); | |
| 29 | 29 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -24,7 +24,8 @@ require('../common'); | |||
| 24 | 24 | const assert = require('assert'); | |
| 25 | 25 | const dns = require('dns'); | |
| 26 | 26 | ||
| 27 | - // Should not raise assertion error. Issue #7070 | ||
| 27 | + // Should not raise assertion error. | ||
| 28 | + // Issue https://github.com/nodejs/node-v0.x-archive/issues/7070 | ||
| 28 | 29 | assert.throws(() => dns.resolveNs([]), // bad name | |
| 29 | 30 | /^Error: "name" argument must be a string$/); | |
| 30 | 31 | assert.throws(() => dns.resolveNs(''), // bad callback | |
| Back | FazBrowse Home | New Git URL |
0 commit comments