build: suppress clang errors building libffi on Windows · nodejs/node@518309c · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 634
• Pull requests 748
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 518309c

Browse filesBrowse the repository at this point in the historyBrowse files

Renegade334

authored and

richardlau

committed

build: suppress clang errors building libffi on Windows

Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk> PR-URL: #64222 Refs: #64040 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Richard Lau <richard.lau@ibm.com>

1 parent bb2eed8 commit 518309c
Copy full SHA for 518309c

1 file changed

+7Lines changed: 7 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• deps/libffi
  • libffi.gyp

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎deps/libffi/libffi.gyp‎

Copy file name to clipboardExpand all lines: deps/libffi/libffi.gyp

+7Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -204,6 +204,13 @@
204	204	},
205	205	],
206	206	'conditions': [
	207	+ ['OS == "win" and clang == 1', {
	208	+ 'msvs_settings': {
	209	+ 'VCCLCompilerTool': {
	210	+ 'AdditionalOptions': ['-Wno-incompatible-pointer-types'],
	211	+ },
	212	+ },
	213	+ }],
207	214	['OS == "win" and (target_arch == "x64" or target_arch == "x86_64")', {
208	215	'actions': [
209	216	{

0 commit comments

Comments

0 (0)