watch: clarify that the fileName parameter can be null · nodejs/node@5183e3a · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 751
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 5183e3a

Browse filesBrowse the repository at this point in the historyBrowse files

lpinca

authored and

richardlau

committed

watch: clarify that the fileName parameter can be null

Add a comment to clarify that the `fileName` parameter can be `null` if the file name cannot be determined. PR-URL: #51305 Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

1 parent 3badc11 commit 5183e3a
Copy full SHA for 5183e3a

1 file changed

+5-2Lines changed: 5 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/watch_mode
  • files_watcher.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/watch_mode/files_watcher.js‎

Copy file name to clipboardExpand all lines: lib/internal/watch_mode/files_watcher.js

+5-2Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -97,8 +97,11 @@ class FilesWatcher extends EventEmitter {
97	97	return;
98	98	}
99	99	const watcher = watch(path, { recursive, signal: this.#signal });
100		- watcher.on('change', (eventType, fileName) => this
101		- .#onChange(recursive ? resolve(path, fileName ?? '') : path));
	100	+ watcher.on('change', (eventType, fileName) => {
	101	+ // `fileName` can be `null` if it cannot be determined. See
	102	+ // https://github.com/nodejs/node/pull/49891#issuecomment-1744673430.
	103	+ this.#onChange(recursive ? resolve(path, fileName ?? '') : path);
	104	+ });
102	105	this.#watchers.set(path, { handle: watcher, recursive });
103	106	if (recursive) {
104	107	this.#removeWatchedChildren(path);

0 commit comments

Comments

0 (0)