Commit 52105ac
doc: remove instructions for unsupported Node.js versions
Remove special V8 maintenance instructions for versions of Node.js prior
to 9.0.0. Perform other minor edits in nearby text.
PR-URL: #39185
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>1 parent eb2d75d commit 52105ac
1 file changed
Lines changed: 4 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -213,17 +213,12 @@ to be cherry-picked in the Node.js repository and V8-CI must test the change. | |||
| 213 | 213 | * Checkout a branch off the appropriate *vY.x-staging* branch (e.g. | |
| 214 | 214 | *v6.x-staging* to fix an issue in V8 5.1). | |
| 215 | 215 | * Cherry-pick the commit(s) from the V8 repository. | |
| 216 | - * On Node.js < 9.0.0: Increase the patch level version in `v8-version.h`. | ||
| 217 | - This will not cause any problems with versioning because V8 will not | ||
| 218 | - publish other patches for this branch, so Node.js can effectively bump the | ||
| 219 | - patch version. | ||
| 220 | - * On Node.js >= 9.0.0: Increase the `v8_embedder_string` number in | ||
| 221 | - `common.gypi`. | ||
| 216 | + * Increase the `v8_embedder_string` number in `common.gypi`. | ||
| 222 | 217 | * In some cases the patch may require extra effort to merge in case V8 has | |
| 223 | - changed substantially. For important issues we may be able to lean on the | ||
| 218 | + changed substantially. For important issues, we may be able to lean on the | ||
| 224 | 219 | V8 team to get help with reimplementing the patch. | |
| 225 | - * Open a cherry-pick PR on `nodejs/node` targeting the *vY.x-staging* branch | ||
| 226 | - and notify the `@nodejs/v8` team. | ||
| 220 | + * Open a cherry-pick pull request on `nodejs/node` targeting the | ||
| 221 | + *vY.x-staging* branch and notify the `@nodejs/v8` team. | ||
| 227 | 222 | * Run the Node.js [V8 CI][] in addition to the [Node.js CI][]. | |
| 228 | 223 | The CI uses the `test-v8` target in the `Makefile`, which uses | |
| 229 | 224 | `tools/make-v8.sh` to reconstruct a git tree in the `deps/v8` directory to | |
0 commit comments