Commit 528edb2
build: ignore empty folders in test-addons-napi
The same as #16031 except
for N-API addons.
PR-URL: #16380
Fixes: #13521
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>1 parent a628455 commit 528edb2
1 file changed
Lines changed: 6 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -299,7 +299,8 @@ test/addons/.buildstamp: config.gypi \ | |||
| 299 | 299 | test/addons/.docbuildstamp | |
| 300 | 300 | # Cannot use $(wildcard test/addons/*/) here, it's evaluated before | |
| 301 | 301 | # embedded addons have been generated from the documentation. | |
| 302 | - # Ignore folders without binding.gyp (#14843) | ||
| 302 | + # Ignore folders without binding.gyp | ||
| 303 | + # (https://github.com/nodejs/node/issues/14843) | ||
| 303 | 304 | @for dirname in test/addons/*/; do \ | |
| 304 | 305 | if [ ! -f "$$PWD/$${dirname}binding.gyp" ]; then \ | |
| 305 | 306 | continue; fi ; \ | |
@@ -337,7 +338,11 @@ test/addons-napi/.buildstamp: config.gypi \ | |||
| 337 | 338 | src/node_api.h src/node_api_types.h | |
| 338 | 339 | # Cannot use $(wildcard test/addons-napi/*/) here, it's evaluated before | |
| 339 | 340 | # embedded addons have been generated from the documentation. | |
| 341 | + # Ignore folders without binding.gyp | ||
| 342 | + # (https://github.com/nodejs/node/issues/14843) | ||
| 340 | 343 | @for dirname in test/addons-napi/*/; do \ | |
| 344 | + if [ ! -f "$$PWD/$${dirname}binding.gyp" ]; then \ | ||
| 345 | + continue; fi ; \ | ||
| 341 | 346 | printf "\nBuilding addon $$PWD/$$dirname\n" ; \ | |
| 342 | 347 | env MAKEFLAGS="-j1" $(NODE) deps/npm/node_modules/node-gyp/bin/node-gyp \ | |
| 343 | 348 | --loglevel=$(LOGLEVEL) rebuild \ | |
0 commit comments