Commit 52a1c18
doc: update git node land instructions for security releases
Signed-off-by: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #63586
Refs: nodejs/node-core-utils#1043
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>1 parent a53b51d commit 52a1c18
1 file changed
Lines changed: 5 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -272,11 +272,12 @@ $ git reset --hard upstream/vN.x | |||
| 272 | 272 | The list of patches to include should be listed in the "Next Security Release" | |
| 273 | 273 | issue in `nodejs-private`. Ask the security release steward if you're unsure. | |
| 274 | 274 | ||
| 275 | - The `git node land` tool does not work with the `nodejs-private` | ||
| 276 | - organization. To land a PR in Node.js private, use `git cherry-pick` to apply | ||
| 277 | - each commit from the PR. You will also need to manually apply the PR | ||
| 278 | - metadata (`PR-URL`, `Reviewed-by`, etc.) by amending the commit messages. If | ||
| 275 | + To use the `git node land` tool to land Pull Requests in the `nodejs-private` | ||
| 276 | + organization, you need to specify the full URL to the Pull Request and make sure | ||
| 277 | + you provide a GitHub token with read permission to the private repository. If | ||
| 279 | 278 | known, additionally include `CVE-ID: CVE-XXXX-XXXXX` in the commit metadata. | |
| 279 | + Make sure to sign and push to resulting commit to the private repository and not | ||
| 280 | + the public one. | ||
| 280 | 281 | ||
| 281 | 282 | **Note**: Do not run CI on the PRs in `nodejs-private` until CI is locked down. | |
| 282 | 283 | You can integrate the PRs into the proposal without running full CI. | |
0 commit comments