| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
1 parent da2cd4a commit 52b3b54
2 files changed
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -12,7 +12,7 @@ This document attempts to outline the current maintenance processes, proposes | |||
| 12 | 12 | a workflow for maintaining the V8 branches in both Node.js LTS and current | |
| 13 | 13 | releases, and discusses how the Node.js and V8 teams at Google can help. | |
| 14 | 14 | ||
| 15 | - ## V8 Release Schedule | ||
| 15 | + ## V8 release schedule | ||
| 16 | 16 | ||
| 17 | 17 | V8 and Chromium follow a | |
| 18 | 18 | [roughly 6-week release cadence][ChromiumReleaseCalendar]. At any given time | |
@@ -30,7 +30,7 @@ For example, at the time of this writing: | |||
| 30 | 30 | ||
| 31 | 31 | All older branches are abandoned and are not maintained by the V8 team. | |
| 32 | 32 | ||
| 33 | - ### V8 Merge Process Overview | ||
| 33 | + ### V8 merge process overview | ||
| 34 | 34 | ||
| 35 | 35 | The process for backporting bug fixes to active branches is officially | |
| 36 | 36 | documented [on the V8 wiki][V8MergingPatching]. The summary of the process is: | |
@@ -48,7 +48,7 @@ documented [on the V8 wiki][V8MergingPatching]. The summary of the process is: | |||
| 48 | 48 | * Merge requests to an abandoned branch will be rejected. | |
| 49 | 49 | * Only bug fixes are accepted for backporting. | |
| 50 | 50 | ||
| 51 | - ## Node.js Support Requirements | ||
| 51 | + ## Node.js support requirements | ||
| 52 | 52 | ||
| 53 | 53 | At any given time Node.js needs to be maintaining a few different V8 branches | |
| 54 | 54 | for the various Current, LTS, and nightly releases. At present this list | |
@@ -146,7 +146,7 @@ abandoned by upstream V8. However, Node.js needs to continue supporting | |||
| 146 | 146 | these branches for many months (Current branches) or several | |
| 147 | 147 | years (LTS branches). | |
| 148 | 148 | ||
| 149 | - ## Maintenance Process | ||
| 149 | + ## Maintenance process | ||
| 150 | 150 | ||
| 151 | 151 | Once a bug in Node.js has been identified to be caused by V8, the first step is | |
| 152 | 152 | to identify the versions of Node.js and V8 affected. The bug may be present in | |
@@ -160,7 +160,7 @@ process. | |||
| 160 | 160 | * Backports identified by the V8 team. Bugs identified by upstream V8 that we | |
| 161 | 161 | haven't encountered in Node.js yet. | |
| 162 | 162 | ||
| 163 | - ### Unfixed Upstream Bugs | ||
| 163 | + ### Unfixed upstream bugs | ||
| 164 | 164 | ||
| 165 | 165 | If the bug can be reproduced on the [Node.js `canary` branch][], Chromium | |
| 166 | 166 | canary, or V8 tip-of-tree, and the test case is valid, then the bug needs to be | |
@@ -176,7 +176,7 @@ fixed upstream first. | |||
| 176 | 176 | branches that are still active or are branches that Node.js cares about. | |
| 177 | 177 | Follow the process for backporting below. | |
| 178 | 178 | ||
| 179 | - ### Backporting to Active Branches | ||
| 179 | + ### Backporting to active branches | ||
| 180 | 180 | ||
| 181 | 181 | If the bug exists in any of the active V8 branches, we may need to get the fix | |
| 182 | 182 | backported. At any given time there are [two active branches][V8ActiveBranches] | |
@@ -205,7 +205,7 @@ backport the fix: | |||
| 205 | 205 | * Once the fix has been merged upstream, it can be picked up during an update of | |
| 206 | 206 | the V8 branch (see below). | |
| 207 | 207 | ||
| 208 | - ### Backporting to Abandoned Branches | ||
| 208 | + ### Backporting to abandoned branches | ||
| 209 | 209 | ||
| 210 | 210 | Abandoned V8 branches are supported in the Node.js repository. The fix needs | |
| 211 | 211 | to be cherry-picked in the Node.js repository and V8-CI must test the change. | |
@@ -278,7 +278,7 @@ PR-URL: https://github.com/nodejs/node/pull/7833 | |||
| 278 | 278 | normal and [V8 CI][] using the Node.js CI system. We only needed to backport | |
| 279 | 279 | to `v6.x` as the other LTS branches weren't affected by this bug. | |
| 280 | 280 | ||
| 281 | - ### Backports Identified by the V8 Team | ||
| 281 | + ### Backports identified by the V8 team | ||
| 282 | 282 | ||
| 283 | 283 | For bugs found through the browser or other channels, the V8 team marks bugs | |
| 284 | 284 | that might be applicable to the abandoned branches in use by Node.js. This is | |
@@ -317,7 +317,7 @@ V8 builds against the version of ICU supplied by Node.js, | |||
| 317 | 317 | see [maintaining-icu.md](./maintaining-icu.md) for special considerations. | |
| 318 | 318 | Specifically, a V8 update may necessitate an ICU update. | |
| 319 | 319 | ||
| 320 | - ### Minor Updates (Patch Level) | ||
| 320 | + ### Minor updates (patch level) | ||
| 321 | 321 | ||
| 322 | 322 | Because there may be floating patches on the version of V8 in Node.js, it is | |
| 323 | 323 | safest to apply the patch level updates as a patch. For example, imagine that | |
@@ -347,7 +347,7 @@ Revision* from the 5.4 branch that can be useful in the update process above. | |||
| 347 | 347 | The [`git-node`][] tool can be used to simplify this task. Run `git node v8 minor` | |
| 348 | 348 | to apply a minor update. | |
| 349 | 349 | ||
| 350 | - ### Major Updates | ||
| 350 | + ### Major updates | ||
| 351 | 351 | ||
| 352 | 352 | We upgrade the version of V8 in Node.js master whenever a V8 release goes stable | |
| 353 | 353 | upstream, that is, whenever a new release of Chrome comes out. | |
@@ -382,7 +382,7 @@ git node v8 major --branch=5.1-lkgr | |||
| 382 | 382 | ||
| 383 | 383 | This should be followed up with manual refloating of all relevant patches. | |
| 384 | 384 | ||
| 385 | - ## Proposal: Using a Fork Repo to Track Upstream V8 | ||
| 385 | + ## Proposal: using a fork repo to track upstream V8 | ||
| 386 | 386 | ||
| 387 | 387 | The fact that Node.js keeps a vendored, potentially edited copy of V8 in deps/ | |
| 388 | 388 | makes the above processes a bit complicated. An alternative proposal would be to | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1,18 +1,18 @@ | |||
| 1 | - # Postmortem Support | ||
| 1 | + # Postmortem support | ||
| 2 | 2 | ||
| 3 | 3 | Postmortem metadata are constants present in the final build which can be used | |
| 4 | 4 | by debuggers and other tools to navigate through internal structures of software | |
| 5 | 5 | when analyzing its memory (either on a running process or a core dump). Node.js | |
| 6 | 6 | provides this metadata in its builds for V8 and Node.js internal structures. | |
| 7 | 7 | ||
| 8 | - ## V8 Postmortem metadata | ||
| 8 | + ## V8 postmortem metadata | ||
| 9 | 9 | ||
| 10 | 10 | V8 prefixes all postmortem constants with `v8dbg_`, and they allow inspection of | |
| 11 | 11 | objects on the heap as well as object properties and references. V8 generates | |
| 12 | 12 | those symbols with a script (`deps/v8/tools/gen-postmortem-metadata.py`), and | |
| 13 | 13 | Node.js always includes these constants in the final build. | |
| 14 | 14 | ||
| 15 | - ## Node.js Debug Symbols | ||
| 15 | + ## Node.js debug symbols | ||
| 16 | 16 | ||
| 17 | 17 | Node.js prefixes all postmortem constants with `nodedbg_`, and they complement | |
| 18 | 18 | V8 constants by providing ways to inspect Node.js-specific structures, like | |
@@ -64,7 +64,7 @@ class ReqWrap : public AsyncWrap { | |||
| 64 | 64 | There are also tests on `test/cctest/test_node_postmortem_metadata.cc` to make | |
| 65 | 65 | sure all Node.js postmortem metadata are calculated correctly. | |
| 66 | 66 | ||
| 67 | - ## Tools and References | ||
| 67 | + ## Tools and references | ||
| 68 | 68 | ||
| 69 | 69 | * [llnode](https://github.com/nodejs/llnode): LLDB plugin | |
| 70 | 70 | * [`mdb_v8`](https://github.com/joyent/mdb_v8): mdb plugin | |
| Back | FazBrowse Home | New Git URL |
0 commit comments