esm: show race error message for inner module job race · nodejs/node@5347c49 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 5347c49

Browse filesBrowse the repository at this point in the historyBrowse files

joyeecheung

authored and

targos

committed

esm: show race error message for inner module job race

The race can not only happen when the ESM is loaded by the CommonJS loader, but can also happen to inner module jobs in the dependency graph. PR-URL: #59519 Fixes: #59366 Refs: https://github.com/abejfehr/node-22.18-issue-repro Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>

1 parent 1474153 commit 5347c49
Copy full SHA for 5347c49

1 file changed

+4Lines changed: 4 additions & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/modules/esm
  • loader.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/modules/esm/loader.js‎

Copy file name to clipboardExpand all lines: lib/internal/modules/esm/loader.js

+4Lines changed: 4 additions & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -471,6 +471,10 @@ class ModuleLoader {
471	471	const resolvedImportAttributes = resolveResult.importAttributes ?? importAttributes;
472	472	let job = this.loadCache.get(url, resolvedImportAttributes.type);
473	473	if (job !== undefined) {
	474	+ // TODO(node:55782): this race may stop happening when the ESM resolution and loading become synchronous.
	475	+ if (!job.module) {
	476	+ assert.fail(getRaceMessage(url, parentURL));
	477	+ }
474	478	// This module is being evaluated, which means it's imported in a previous link
475	479	// in a cycle.
476	480	if (job.module.getStatus() === kEvaluating) {

0 commit comments

Comments

0 (0)