lib: stop installing webcrypto if `no_browser_globals` is `true` · nodejs/node@53e2e8c · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 53e2e8c

Browse filesBrowse the repository at this point in the historyBrowse files

Mesteery

authored and

bengl

committed

lib: stop installing webcrypto if no_browser_globals is true

Refs: #41969 (comment) PR-URL: #41971 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Nitzan Uziely <linkgoron@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>

1 parent ec5b594 commit 53e2e8c
Copy full SHA for 53e2e8c

1 file changed

+2-1Lines changed: 2 additions & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/bootstrap
  • pre_execution.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/bootstrap/pre_execution.js‎

Copy file name to clipboardExpand all lines: lib/internal/bootstrap/pre_execution.js

+2-1Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -186,7 +186,8 @@ function setupFetch() {
186	186	// TODO(aduh95): move this to internal/bootstrap/browser when the CLI flag is
187	187	// removed.
188	188	function setupWebCrypto() {
189		- if (!getOptionValue('--experimental-global-webcrypto')) {
	189	+ if (process.config.variables.node_no_browser_globals ||
	190	+ !getOptionValue('--experimental-global-webcrypto')) {
190	191	return;
191	192	}
192	193

0 commit comments

Comments

0 (0)