Commit 53f2848
test: favor assertions over console logging
Communicate about leaked globals via `AssertionError` rather than
`console.log()`.
PR-URL: #11547
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent d622b67 commit 53f2848
1 file changed
Lines changed: 1 addition & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -360,8 +360,7 @@ process.on('exit', function() { | |||
| 360 | 360 | if (!exports.globalCheck) return; | |
| 361 | 361 | var leaked = leakedGlobals(); | |
| 362 | 362 | if (leaked.length > 0) { | |
| 363 | - console.error('Unknown globals: %s', leaked); | ||
| 364 | - assert.ok(false, 'Unknown global found'); | ||
| 363 | + exports.fail(`Unexpected global(s) found: ${leaked.join(', ')}`); | ||
| 365 | 364 | } | |
| 366 | 365 | }); | |
| 367 | 366 | ||
0 commit comments