doc: outline when origin is set to unhandledRejection · nodejs/node@5436057 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 638
• Pull requests 751
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 5436057

Browse filesBrowse the repository at this point in the historyBrowse files

BridgeAR

authored and

codebytere

committed

doc: outline when origin is set to unhandledRejection

The `uncaughtException` listener's origin argument was ambiguous about unhandled rejections. This should clarify when origin is set to `'unhandledRejection'`. Fixes: #32907 Signed-off-by: Ruben Bridgewater <ruben@bridgewater.de> PR-URL: #33530 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

1 parent a9c5b33 commit 5436057
Copy full SHA for 5436057

1 file changed

+4-2Lines changed: 4 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• doc/api
  • process.md

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎doc/api/process.md‎

Copy file name to clipboardExpand all lines: doc/api/process.md

+4-2Lines changed: 4 additions & 2 deletions

• Display the source diff
• Display the rich diff

Original file line number	Diff line number	Diff line change
@@ -231,8 +231,9 @@ changes:
231	231
232	232	* `err` {Error} The uncaught exception.
233	233	* `origin` {string} Indicates if the exception originates from an unhandled
234		- rejection or from synchronous errors. Can either be `'uncaughtException'` or
235		- `'unhandledRejection'`.
	234	+ rejection or from an synchronous error. Can either be `'uncaughtException'` or
	235	+ `'unhandledRejection'`. The latter is only used in conjunction with the
	236	+ [`--unhandled-rejections`][] flag set to `strict` and an unhandled rejection.
236	237
237	238	The `'uncaughtException'` event is emitted when an uncaught JavaScript
238	239	exception bubbles all the way back to the event loop. By default, Node.js
@@ -2535,6 +2536,7 @@ cases:
2535	2536	[`'exit'`]: #process_event_exit
2536	2537	[`'message'`]: child_process.html#child_process_event_message
2537	2538	[`'uncaughtException'`]: #process_event_uncaughtexception
	2539	+ [`--unhandled-rejections`]: cli.html#cli_unhandled_rejections_mode
2538	2540	[`Buffer`]: buffer.html
2539	2541	[`ChildProcess.disconnect()`]: child_process.html#child_process_subprocess_disconnect
2540	2542	[`ChildProcess.send()`]: child_process.html#child_process_subprocess_send_message_sendhandle_options_callback

0 commit comments

Comments

0 (0)