Commit 5438611
src: use NewFromUtf8Literal in GetLinkedBinding
This commit changes the usage of NewFromUtf8 to NewFromUtf8Literal.
The motivation for this change is that NewFromUtf8Literal is a templated
function that takes a char[N] argument so the length of the string can
be asserted at compile time, avoiding length checks that NewFromUtf8
performs.
My understanding is that since these checks can be performed at compile
time, checking that the string is not zero and checking that it is not
greater than kMaxLength, this function does not have to return a
MaybeLocal<String> and can return a Local<String> meaning that the
additional ToLocalChecked call is avoided.
PR-URL: #33552
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 8c9e3a9 commit 5438611
1 file changed
Lines changed: 1 addition & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -233,7 +233,6 @@ using v8::Exception; | |||
| 233 | 233 | using v8::Function; | |
| 234 | 234 | using v8::FunctionCallbackInfo; | |
| 235 | 235 | using v8::Local; | |
| 236 | - using v8::NewStringType; | ||
| 237 | 236 | using v8::Object; | |
| 238 | 237 | using v8::String; | |
| 239 | 238 | using v8::Value; | |
@@ -644,8 +643,7 @@ void GetLinkedBinding(const FunctionCallbackInfo<Value>& args) { | |||
| 644 | 643 | Local<Object> module = Object::New(env->isolate()); | |
| 645 | 644 | Local<Object> exports = Object::New(env->isolate()); | |
| 646 | 645 | Local<String> exports_prop = | |
| 647 | - String::NewFromUtf8(env->isolate(), "exports", NewStringType::kNormal) | ||
| 648 | - .ToLocalChecked(); | ||
| 646 | + String::NewFromUtf8Literal(env->isolate(), "exports"); | ||
| 649 | 647 | module->Set(env->context(), exports_prop, exports).Check(); | |
| 650 | 648 | ||
| 651 | 649 | if (mod->nm_context_register_func != nullptr) { | |
0 commit comments