module: simplify tryStatSync with throwIfNoEntry option · nodejs/node@543ecbd · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 638
• Pull requests 751
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 543ecbd

Browse filesBrowse the repository at this point in the historyBrowse files

aduh95

authored and

ruyadorno

committed

module: simplify tryStatSync with throwIfNoEntry option

PR-URL: #36971 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

1 parent 5693ed9 commit 543ecbd
Copy full SHA for 543ecbd

1 file changed

+2-7Lines changed: 2 additions & 7 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal/modules/esm
  • resolve.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/modules/esm/resolve.js‎

Copy file name to clipboardExpand all lines: lib/internal/modules/esm/resolve.js

+2-7Lines changed: 2 additions & 7 deletions

Original file line number	Diff line number	Diff line change
@@ -104,13 +104,8 @@ function getConditionsSet(conditions) {
104	104	const realpathCache = new SafeMap();
105	105	const packageJSONCache = new SafeMap(); /* string -> PackageConfig */
106	106
107		- function tryStatSync(path) {
108		- try {
109		- return statSync(path);
110		- } catch {
111		- return new Stats();
112		- }
113		- }
	107	+ const tryStatSync =
	108	+ (path) => statSync(path, { throwIfNoEntry: false }) ?? new Stats();
114	109
115	110	function getPackageConfig(path, specifier, base) {
116	111	const existing = packageJSONCache.get(path);

0 commit comments

Comments

0 (0)