Commit 5451975
deps: patch V8 to run on older XCode versions
Patch V8 (compiler/js-heap-broker.cc) to remove the use of an optional
property, which is a fairly new C++ feature, since that requires a newer
XCode version than the minimum requirement in BUILDING.md and thus
breaks CI.
PR-URL: #32116
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>1 parent c460f7a commit 5451975
3 files changed
Lines changed: 3 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -36,7 +36,7 @@ | |||
| 36 | 36 | ||
| 37 | 37 | # Reset this number to 0 on major V8 upgrades. | |
| 38 | 38 | # Increment by one for each non-official patch applied to deps/v8. | |
| 39 | - 'v8_embedder_string': '-node.1', | ||
| 39 | + 'v8_embedder_string': '-node.2', | ||
| 40 | 40 | ||
| 41 | 41 | ##### V8 defaults for Node.js ##### | |
| 42 | 42 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -4466,6 +4466,7 @@ GlobalAccessFeedback::GlobalAccessFeedback(PropertyCellRef cell, | |||
| 4466 | 4466 | ||
| 4467 | 4467 | GlobalAccessFeedback::GlobalAccessFeedback(FeedbackSlotKind slot_kind) | |
| 4468 | 4468 | : ProcessedFeedback(kGlobalAccess, slot_kind), | |
| 4469 | + cell_or_context_(base::nullopt), | ||
| 4469 | 4470 | index_and_immutable_(0 /* doesn't matter */) { | |
| 4470 | 4471 | DCHECK(IsGlobalICKind(slot_kind)); | |
| 4471 | 4472 | } | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -286,7 +286,7 @@ Interpreter::NewSourcePositionCollectionJob( | |||
| 286 | 286 | auto job = std::make_unique<InterpreterCompilationJob>(parse_info, literal, | |
| 287 | 287 | allocator, nullptr); | |
| 288 | 288 | job->compilation_info()->SetBytecodeArray(existing_bytecode); | |
| 289 | - return job; | ||
| 289 | + return std::unique_ptr<UnoptimizedCompilationJob> { static_cast<UnoptimizedCompilationJob*>(job.release()) }; | ||
| 290 | 290 | } | |
| 291 | 291 | ||
| 292 | 292 | void Interpreter::ForEachBytecode( | |
0 commit comments