Commit 548137f
errors: simplify ERR_REQUIRE_ESM message generation
Because of the condition that starts the `if` block, we know that
`parentPath` must be truthy. So there is no need to check for that in
the template string that generates the error message.
PR-URL: #35123
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>1 parent 5405e62 commit 548137f
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1296,7 +1296,7 @@ E('ERR_REQUIRE_ESM', | |||
| 1296 | 1296 | filename : path.basename(filename); | |
| 1297 | 1297 | msg += | |
| 1298 | 1298 | '\nrequire() of ES modules is not supported.\nrequire() of ' + | |
| 1299 | - `${filename} ${parentPath ? `from ${parentPath} ` : ''}` + | ||
| 1299 | + `${filename} from ${parentPath} ` + | ||
| 1300 | 1300 | 'is an ES module file as it is a .js file whose nearest parent ' + | |
| 1301 | 1301 | 'package.json contains "type": "module" which defines all .js ' + | |
| 1302 | 1302 | 'files in that package scope as ES modules.\nInstead rename ' + | |
0 commit comments