Commit 54a1078
test: avoid leftover report file
test-windows-failed-heap-allocation forces a out of mem crash resulting
in a report file. To avoid a leftover in repo the child is started in a
tmp folder like in test-report-fatal-error.
PR-URL: #30925
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>1 parent 0b3951a commit 54a1078
1 file changed
Lines changed: 5 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -14,9 +14,13 @@ if (process.argv[2] === 'heapBomb') { | |||
| 14 | 14 | fn(2); | |
| 15 | 15 | } | |
| 16 | 16 | ||
| 17 | + // Run child in tmpdir to avoid report files in repo | ||
| 18 | + const tmpdir = require('../common/tmpdir'); | ||
| 19 | + tmpdir.refresh(); | ||
| 20 | + | ||
| 17 | 21 | // --max-old-space-size=3 is the min 'old space' in V8, explodes fast | |
| 18 | 22 | const cmd = `"${process.execPath}" --max-old-space-size=3 "${__filename}"`; | |
| 19 | - exec(`${cmd} heapBomb`, common.mustCall((err) => { | ||
| 23 | + exec(`${cmd} heapBomb`, { cwd: tmpdir.path }, common.mustCall((err) => { | ||
| 20 | 24 | const msg = `Wrong exit code of ${err.code}! Expected 134 for abort`; | |
| 21 | 25 | // Note: common.nodeProcessAborted() is not asserted here because it | |
| 22 | 26 | // returns true on 134 as well as 0xC0000005 (V8's base::OS::Abort) | |
0 commit comments