lib: replace every Symbol.for by SymbolFor primordials · nodejs/node@54aa3b9 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 54aa3b9

Browse filesBrowse the repository at this point in the historyBrowse files

Sebastien-Ahkrin

authored and

targos

committed

lib: replace every Symbol.for by SymbolFor primordials

PR-URL: #30857 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>

1 parent c6535c0 commit 54aa3b9
Copy full SHA for 54aa3b9

3 files changed

+6-3Lines changed: 6 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal
  • errors.js
  • util.js
  • worker.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/errors.js‎

Copy file name to clipboardExpand all lines: lib/internal/errors.js

+2-1Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -17,6 +17,7 @@ const {
17	17	ObjectDefineProperty,
18	18	ObjectKeys,
19	19	Symbol,
	20	+ SymbolFor,
20	21	} = primordials;
21	22
22	23	const messages = new Map();
@@ -207,7 +208,7 @@ class SystemError extends Error {
207	208	return `${this.name} [${this.code}]: ${this.message}`;
208	209	}
209	210
210		- [Symbol.for('nodejs.util.inspect.custom')](recurseTimes, ctx) {
	211	+ [SymbolFor('nodejs.util.inspect.custom')](recurseTimes, ctx) {
211	212	return lazyInternalUtilInspect().inspect(this, {
212	213	...ctx,
213	214	getters: true,

Collapse file

‎lib/internal/util.js‎

Copy file name to clipboardExpand all lines: lib/internal/util.js

+2-1Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -12,6 +12,7 @@ const {
12	12	ObjectSetPrototypeOf,
13	13	ReflectConstruct,
14	14	Symbol,
	15	+ SymbolFor,
15	16	} = primordials;
16	17
17	18	const {
@@ -425,7 +426,7 @@ module.exports = {
425	426
426	427	// Symbol used to provide a custom inspect function for an object as an
427	428	// alternative to using 'inspect'
428		- customInspectSymbol: Symbol.for('nodejs.util.inspect.custom'),
	429	+ customInspectSymbol: SymbolFor('nodejs.util.inspect.custom'),
429	430
430	431	// Used by the buffer module to capture an internal reference to the
431	432	// default isEncoding implementation, just in case userland overrides it.

Collapse file

‎lib/internal/worker.js‎

Copy file name to clipboardExpand all lines: lib/internal/worker.js

+2-1Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -8,6 +8,7 @@ const {
8	8	ObjectCreate,
9	9	ObjectEntries,
10	10	Symbol,
	11	+ SymbolFor,
11	12	} = primordials;
12	13
13	14	const EventEmitter = require('events');
@@ -62,7 +63,7 @@ const kOnCouldNotSerializeErr = Symbol('kOnCouldNotSerializeErr');
62	63	const kOnErrorMessage = Symbol('kOnErrorMessage');
63	64	const kParentSideStdio = Symbol('kParentSideStdio');
64	65
65		- const SHARE_ENV = Symbol.for('nodejs.worker_threads.SHARE_ENV');
	66	+ const SHARE_ENV = SymbolFor('nodejs.worker_threads.SHARE_ENV');
66	67	const debug = require('internal/util/debuglog').debuglog('worker');
67	68
68	69	let cwdCounter;

0 commit comments

Comments

0 (0)