Commit 5503092
lib: scope loop variables
Refactor instances in `lib` where a loop variable is redeclared in the
same scope with `var`. In these cases, `let` can be used to scope the
variable declarations more precisely.
PR-URL: #4965
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 3845940 commit 5503092
2 files changed
Lines changed: 4 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -282,7 +282,7 @@ win32.relative = function(from, to) { | |||
| 282 | 282 | } | |
| 283 | 283 | ||
| 284 | 284 | var outputParts = []; | |
| 285 | - for (var i = samePartsLength; i < lowerFromParts.length; i++) { | ||
| 285 | + for (var j = samePartsLength; j < lowerFromParts.length; j++) { | ||
| 286 | 286 | outputParts.push('..'); | |
| 287 | 287 | } | |
| 288 | 288 | ||
@@ -511,7 +511,7 @@ posix.relative = function(from, to) { | |||
| 511 | 511 | } | |
| 512 | 512 | ||
| 513 | 513 | var outputParts = []; | |
| 514 | - for (var i = samePartsLength; i < fromParts.length; i++) { | ||
| 514 | + for (var j = samePartsLength; j < fromParts.length; j++) { | ||
| 515 | 515 | outputParts.push('..'); | |
| 516 | 516 | } | |
| 517 | 517 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -13,8 +13,8 @@ const formatRegExp = /%[sdj%]/g; | |||
| 13 | 13 | exports.format = function(f) { | |
| 14 | 14 | if (typeof f !== 'string') { | |
| 15 | 15 | var objects = []; | |
| 16 | - for (var i = 0; i < arguments.length; i++) { | ||
| 17 | - objects.push(inspect(arguments[i])); | ||
| 16 | + for (var index = 0; index < arguments.length; index++) { | ||
| 17 | + objects.push(inspect(arguments[index])); | ||
| 18 | 18 | } | |
| 19 | 19 | return objects.join(' '); | |
| 20 | 20 | } | |
0 commit comments