src: fix query/fragment serialization in URL::SerializeURL · nodejs/node@554cd2c · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 559
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 554cd2c

Browse filesBrowse the repository at this point in the historyBrowse files

addaleax

authored and

bengl

committed

src: fix query/fragment serialization in URL::SerializeURL

These are presumably typos. PR-URL: #41759 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>

1 parent 626577e commit 554cd2c
Copy full SHA for 554cd2c

1 file changed

+2-2Lines changed: 2 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src
  • node_url.cc

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/node_url.cc‎

Copy file name to clipboardExpand all lines: src/node_url.cc

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -1576,10 +1576,10 @@ std::string URL::SerializeURL(const struct url_data* url,
1576	1576	}
1577	1577	}
1578	1578	if (url->flags & URL_FLAGS_HAS_QUERY) {
1579		- output = "?" + url->query;
	1579	+ output += "?" + url->query;
1580	1580	}
1581	1581	if (!exclude && url->flags & URL_FLAGS_HAS_FRAGMENT) {
1582		- output = "#" + url->fragment;
	1582	+ output += "#" + url->fragment;
1583	1583	}
1584	1584	return output;
1585	1585	}

0 commit comments

Comments

0 (0)