Commit 55af327
benchmark: track exec time in next-tick-exec
The next-tick-exec benchmarks were meant to track nextTick execution
time but due to an error, they actually track addition and execution.
PR-URL: #20462
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent cfb2f34 commit 55af327
2 files changed
Lines changed: 12 additions & 10 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -5,8 +5,11 @@ const bench = common.createBenchmark(main, { | |||
| 5 | 5 | }); | |
| 6 | 6 | ||
| 7 | 7 | function main({ n }) { | |
| 8 | + function onNextTick(i) { | ||
| 9 | + if (i + 1 === n) | ||
| 10 | + bench.end(n); | ||
| 11 | + } | ||
| 8 | 12 | ||
| 9 | - bench.start(); | ||
| 10 | 13 | for (var i = 0; i < n; i++) { | |
| 11 | 14 | if (i % 4 === 0) | |
| 12 | 15 | process.nextTick(onNextTick, i, true, 10, 'test'); | |
@@ -17,8 +20,6 @@ function main({ n }) { | |||
| 17 | 20 | else | |
| 18 | 21 | process.nextTick(onNextTick, i); | |
| 19 | 22 | } | |
| 20 | - function onNextTick(i) { | ||
| 21 | - if (i + 1 === n) | ||
| 22 | - bench.end(n); | ||
| 23 | - } | ||
| 23 | + | ||
| 24 | + bench.start(); | ||
| 24 | 25 | } | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -5,13 +5,14 @@ const bench = common.createBenchmark(main, { | |||
| 5 | 5 | }); | |
| 6 | 6 | ||
| 7 | 7 | function main({ n }) { | |
| 8 | - | ||
| 9 | - bench.start(); | ||
| 10 | - for (var i = 0; i < n; i++) { | ||
| 11 | - process.nextTick(onNextTick, i); | ||
| 12 | - } | ||
| 13 | 8 | function onNextTick(i) { | |
| 14 | 9 | if (i + 1 === n) | |
| 15 | 10 | bench.end(n); | |
| 16 | 11 | } | |
| 12 | + | ||
| 13 | + for (var i = 0; i < n; i++) { | ||
| 14 | + process.nextTick(onNextTick, i); | ||
| 15 | + } | ||
| 16 | + | ||
| 17 | + bench.start(); | ||
| 17 | 18 | } | |
0 commit comments