Commit 560d8ee
test: delay child exit in AIX for pseudo-tty tests
The tests in pseudo-tty takes the form of child node writing some data
and exiting, while parent python consume them through pseudo tty
implementations, and validate the result.
While there is no synchronization between child and parent, this works
for most platforms, except AIX, where the child exits even before the
parent could setup the read loop, under race conditions
Fixing the race condition is ideally done through sending ACK messages
to and forth, but involves massive changes and have side effect. The
workaround is to address them in AIX alone, by adding a reasonable
delay.
PR-URL: #11715
Fixes: #7973
Fixes: #9765
Fixes: #11541
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>1 parent f9c831f commit 560d8ee
4 files changed
Lines changed: 19 additions & 10 deletions
File tree
- test/pseudo-tty
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1,7 +1,7 @@ | |||
| 1 | 1 | // https://github.com/nodejs/node/issues/6456#issuecomment-219320599 | |
| 2 | 2 | // https://gist.github.com/isaacs/1495b91ec66b21d30b10572d72ad2cdd | |
| 3 | 3 | 'use strict'; | |
| 4 | - require('../common'); | ||
| 4 | + const common = require('../common'); | ||
| 5 | 5 | ||
| 6 | 6 | // 1000 bytes wrapped at 50 columns | |
| 7 | 7 | // \n turns into a double-byte character | |
@@ -11,5 +11,9 @@ let out = ('o'.repeat(48) + '\n').repeat(20); | |||
| 11 | 11 | // This results in 1025 bytes, just enough to overflow the 1kb OS X TTY buffer. | |
| 12 | 12 | out += 'o'.repeat(24) + 'O'; | |
| 13 | 13 | ||
| 14 | - process.stdout.write(out); | ||
| 15 | - process.exit(0); | ||
| 14 | + // In AIX, the child exits even before the python parent | ||
| 15 | + // can setup the readloop. Provide a reasonable delay. | ||
| 16 | + setTimeout(function() { | ||
| 17 | + process.stdout.write(out); | ||
| 18 | + process.exit(0); | ||
| 19 | + }, common.isAix ? 200 : 0); | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1,7 +1,7 @@ | |||
| 1 | 1 | // https://github.com/nodejs/node/issues/6456#issuecomment-219320599 | |
| 2 | 2 | // https://gist.github.com/isaacs/1495b91ec66b21d30b10572d72ad2cdd | |
| 3 | 3 | 'use strict'; | |
| 4 | - require('../common'); | ||
| 4 | + const common = require('../common'); | ||
| 5 | 5 | ||
| 6 | 6 | // 1000 bytes wrapped at 50 columns | |
| 7 | 7 | // \n turns into a double-byte character | |
@@ -13,5 +13,9 @@ out += 'o'.repeat(24) + 'O'; | |||
| 13 | 13 | ||
| 14 | 14 | const err = '__This is some stderr__'; | |
| 15 | 15 | ||
| 16 | - process.stdout.write(out); | ||
| 17 | - process.stderr.write(err); | ||
| 16 | + // In AIX, the child exits even before the python parent | ||
| 17 | + // can setup the readloop. Provide a reasonable delay. | ||
| 18 | + setTimeout(function() { | ||
| 19 | + process.stdout.write(out); | ||
| 20 | + process.stderr.write(err); | ||
| 21 | + }, common.isAix ? 200 : 0); | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1,8 +1,5 @@ | |||
| 1 | 1 | prefix pseudo-tty | |
| 2 | 2 | ||
| 3 | 3 | [$system==aix] | |
| 4 | - # test issue only, covered under https://github.com/nodejs/node/issues/7973 | ||
| 5 | - no_dropped_stdio : SKIP | ||
| 6 | - no_interleaved_stdio : SKIP | ||
| 7 | 4 | # being investigated under https://github.com/nodejs/node/issues/9728 | |
| 8 | 5 | test-tty-wrap : FAIL, PASS | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -27,4 +27,8 @@ process.stdout._refreshSize = wrap(originalRefreshSizeStdout, | |||
| 27 | 27 | process.stdout, | |
| 28 | 28 | 'calling stdout._refreshSize'); | |
| 29 | 29 | ||
| 30 | - process.emit('SIGWINCH'); | ||
| 30 | + // In AIX, the child exits even before the python parent | ||
| 31 | + // can setup the readloop. Provide a reasonable delay. | ||
| 32 | + setTimeout(function() { | ||
| 33 | + process.emit('SIGWINCH'); | ||
| 34 | + }, common.isAix ? 200 : 0); | ||
0 commit comments