test: permit test-signalwrap to work without test runner · nodejs/node@561d504 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 637
• Pull requests 746
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 561d504

Browse filesBrowse the repository at this point in the historyBrowse files

Trott

authored and

BridgeAR

committed

test: permit test-signalwrap to work without test runner

test/async-hooks/test-signalwrap.js passes with the test.py test runner but fails if run directly with the `node` executable. Modify the test so it passes in both cases. PR-URL: #28306 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net>

1 parent 6a7d24b commit 561d504
Copy full SHA for 561d504

1 file changed

+7-2Lines changed: 7 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/async-hooks
  • test-signalwrap.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/async-hooks/test-signalwrap.js‎

Copy file name to clipboardExpand all lines: test/async-hooks/test-signalwrap.js

+7-2Lines changed: 7 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -55,8 +55,13 @@ function onsigusr2() {
55	55	process.on('SIGUSR2', common.mustCall(onsigusr2Again));
56	56
57	57	const as = hooks.activitiesOfTypes('SIGNALWRAP');
58		- assert.strictEqual(as.length, 2);
59		- signal2 = as[1];
	58	+ // The isTTY checks are needed to allow test to work whether run with
	59	+ // test.py or directly with the node executable. The third signal event
	60	+ // listener is the SIGWINCH handler that node installs when it thinks
	61	+ // process.stdout is a tty.
	62	+ const expectedLen = 2 + (!!process.stdout.isTTY || !!process.stderr.isTTY);
	63	+ assert.strictEqual(as.length, expectedLen);
	64	+ signal2 = as[expectedLen - 1]; // Last item in the array.
60	65	assert.strictEqual(signal2.type, 'SIGNALWRAP');
61	66	assert.strictEqual(typeof signal2.uid, 'number');
62	67	assert.strictEqual(typeof signal2.triggerAsyncId, 'number');

0 commit comments

Comments

0 (0)