Commit 5620b2b
committed
tools: improve release proposal PR opening
- Open as draft. The releaser should review the PR and mark it as ready.
- Add the "release" label.
- Assign the releaser to the PR so it's clearer who's in charge and
they can find it more easily. This will also notify and subscribe
them to the PR.
PR-URL: #56161
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>1 parent fd55d3c commit 5620b2b
2 files changed
Lines changed: 5 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -78,7 +78,7 @@ jobs: | |||
| 78 | 78 | run: | | |
| 79 | 79 | git update-index --assume-unchanged tools/actions/create-release.sh | |
| 80 | 80 | curl -fsSLo tools/actions/create-release.sh https://github.com/${GITHUB_REPOSITORY}/raw/${GITHUB_SHA}/tools/actions/create-release.sh | |
| 81 | - ./tools/actions/create-release.sh "${RELEASE_DATE}" "${RELEASE_LINE}" | ||
| 81 | + ./tools/actions/create-release.sh "${RELEASE_DATE}" "${RELEASE_LINE}" "${GITHUB_ACTOR}" | ||
| 82 | 82 | env: | |
| 83 | 83 | GH_TOKEN: ${{ github.token }} | |
| 84 | 84 | # We want the bot to push the push the release commit so CI runs on it. | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -7,6 +7,7 @@ BOT_TOKEN=${BOT_TOKEN:-} | |||
| 7 | 7 | ||
| 8 | 8 | RELEASE_DATE=$1 | |
| 9 | 9 | RELEASE_LINE=$2 | |
| 10 | + RELEASER=$3 | ||
| 10 | 11 | ||
| 11 | 12 | if [ -z "$RELEASE_DATE" ] || [ -z "$RELEASE_LINE" ]; then | |
| 12 | 13 | echo "Usage: $0 <RELEASE_DATE> <RELEASE_LINE>" | |
@@ -48,7 +49,7 @@ PR_URL="$(gh api \ | |||
| 48 | 49 | -H "Accept: application/vnd.github+json" \ | |
| 49 | 50 | -H "X-GitHub-Api-Version: 2022-11-28" \ | |
| 50 | 51 | "/repos/${GITHUB_REPOSITORY}/pulls" \ | |
| 51 | - -f "title=$TITLE" -f "body=$TEMP_BODY" -f "head=$HEAD_BRANCH" -f "base=v$RELEASE_LINE.x")" | ||
| 52 | + -f "title=$TITLE" -f "body=$TEMP_BODY" -f "head=$HEAD_BRANCH" -f "base=v$RELEASE_LINE.x" -f draft=true)" | ||
| 52 | 53 | ||
| 53 | 54 | # Push the release commit to the proposal branch using `BOT_TOKEN` from the env | |
| 54 | 55 | node --input-type=module - \ | |
@@ -124,3 +125,5 @@ if (data.errors?.length) { | |||
| 124 | 125 | } | |
| 125 | 126 | console.log(util.inspect(data, { depth: Infinity })); | |
| 126 | 127 | EOF | |
| 128 | + | ||
| 129 | + gh pr edit "$PR_URL" --add-label release --add-assignee "$RELEASER" | ||
0 commit comments