Commit 562168f
benchmark: apply highWaterMark in webstreams pipe-to
The highWaterMark values were passed as properties of the underlying
source and sink dictionaries, where they are ignored: a queuing
strategy's highWaterMark is read from the constructors' second argument.
Every configuration therefore measured the identical workload at the
default highWaterMark of 1, which also explains the historically high
run-to-run variance of this benchmark family.
Pass the strategies as the constructors' second argument and cover the
default (1) alongside buffered (1024, 4096) configurations.
Signed-off-by: Matteo Collina <hello@matteocollina.com>
PR-URL: #65138
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gürgün Dayıoğlu <hey@gurgun.day>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>1 parent 5edffb5 commit 562168f
1 file changed
Lines changed: 4 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -7,29 +7,27 @@ const { | |||
| 7 | 7 | ||
| 8 | 8 | const bench = common.createBenchmark(main, { | |
| 9 | 9 | n: [5e5], | |
| 10 | - highWaterMarkR: [512, 1024, 2048, 4096], | ||
| 11 | - highWaterMarkW: [512, 1024, 2048, 4096], | ||
| 10 | + highWaterMarkR: [1, 1024, 4096], | ||
| 11 | + highWaterMarkW: [1, 1024, 4096], | ||
| 12 | 12 | }); | |
| 13 | 13 | ||
| 14 | 14 | ||
| 15 | 15 | async function main({ n, highWaterMarkR, highWaterMarkW }) { | |
| 16 | 16 | const b = Buffer.alloc(1024); | |
| 17 | 17 | let i = 0; | |
| 18 | 18 | const rs = new ReadableStream({ | |
| 19 | - highWaterMark: highWaterMarkR, | ||
| 20 | 19 | pull: function(controller) { | |
| 21 | 20 | if (i++ < n) { | |
| 22 | 21 | controller.enqueue(b); | |
| 23 | 22 | } else { | |
| 24 | 23 | controller.close(); | |
| 25 | 24 | } | |
| 26 | 25 | }, | |
| 27 | - }); | ||
| 26 | + }, { highWaterMark: highWaterMarkR }); | ||
| 28 | 27 | const ws = new WritableStream({ | |
| 29 | - highWaterMark: highWaterMarkW, | ||
| 30 | 28 | write(chunk, controller) {}, | |
| 31 | 29 | close() { bench.end(n); }, | |
| 32 | - }); | ||
| 30 | + }, { highWaterMark: highWaterMarkW }); | ||
| 33 | 31 | ||
| 34 | 32 | bench.start(); | |
| 35 | 33 | rs.pipeTo(ws); | |
0 commit comments