src: remove HandleWrap instances from list once closed · nodejs/node@564c18e · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 632
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 564c18e

Browse filesBrowse the repository at this point in the historyBrowse files

addaleax

authored and

MylesBorins

committed

src: remove HandleWrap instances from list once closed

This allows keeping `BaseObjectPtr`s to `HandleWrap` instances. Previously, the pointer kept the `HandleWrap` object alive, leaving the Environment cleanup code that waits for the handle list to drain in a busy loop, because only the `HandleWrap` destructor removed the item from the list. Refs: nodejs/quic#165 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> PR-URL: #30374 Refs: nodejs/quic#141 Refs: nodejs/quic#149 Refs: nodejs/quic#141 Reviewed-By: David Carlier <devnexen@gmail.com>

1 parent 4222f24 commit 564c18e
Copy full SHA for 564c18e

1 file changed

+1Lines changed: 1 addition & 0 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• src
  • handle_wrap.cc

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎src/handle_wrap.cc‎

Copy file name to clipboardExpand all lines: src/handle_wrap.cc

+1Lines changed: 1 addition & 0 deletions

Original file line number	Diff line number	Diff line change
@@ -128,6 +128,7 @@ void HandleWrap::OnClose(uv_handle_t* handle) {
128	128	wrap->state_ = kClosed;
129	129
130	130	wrap->OnClose();
	131	+ wrap->handle_wrap_queue_.Remove();
131	132
132	133	if (!wrap->persistent().IsEmpty() &&
133	134	wrap->object()->Has(env->context(), env->handle_onclose_symbol())

0 commit comments

Comments

0 (0)