Commit 56989d3
authored
src: remove deprecated node::EmitBeforeExit and node::EmitExit
PR-URL: #58469
Refs: #35486
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>1 parent 41ab185 commit 56989d3
2 files changed
Lines changed: 0 additions & 16 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -26,10 +26,6 @@ void AtExit(Environment* env, void (*cb)(void* arg), void* arg) { | |||
| 26 | 26 | env->AtExit(cb, arg); | |
| 27 | 27 | } | |
| 28 | 28 | ||
| 29 | - void EmitBeforeExit(Environment* env) { | ||
| 30 | - USE(EmitProcessBeforeExit(env)); | ||
| 31 | - } | ||
| 32 | - | ||
| 33 | 29 | Maybe<bool> EmitProcessBeforeExit(Environment* env) { | |
| 34 | 30 | TRACE_EVENT0(TRACING_CATEGORY_NODE1(environment), "BeforeExit"); | |
| 35 | 31 | if (!env->destroy_async_id_list()->empty()) | |
@@ -50,14 +46,6 @@ Maybe<bool> EmitProcessBeforeExit(Environment* env) { | |||
| 50 | 46 | : Just(true); | |
| 51 | 47 | } | |
| 52 | 48 | ||
| 53 | - static ExitCode EmitExitInternal(Environment* env) { | ||
| 54 | - return EmitProcessExitInternal(env).FromMaybe(ExitCode::kGenericUserError); | ||
| 55 | - } | ||
| 56 | - | ||
| 57 | - int EmitExit(Environment* env) { | ||
| 58 | - return static_cast<int>(EmitExitInternal(env)); | ||
| 59 | - } | ||
| 60 | - | ||
| 61 | 49 | Maybe<ExitCode> EmitProcessExitInternal(Environment* env) { | |
| 62 | 50 | // process.emit('exit') | |
| 63 | 51 | Isolate* isolate = env->isolate(); | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -844,13 +844,9 @@ NODE_EXTERN void SetTracingController(v8::TracingController* controller); | |||
| 844 | 844 | // Run `process.emit('beforeExit')` as it would usually happen when Node.js is | |
| 845 | 845 | // run in standalone mode. | |
| 846 | 846 | NODE_EXTERN v8::Maybe<bool> EmitProcessBeforeExit(Environment* env); | |
| 847 | - NODE_DEPRECATED("Use Maybe version (EmitProcessBeforeExit) instead", | ||
| 848 | - NODE_EXTERN void EmitBeforeExit(Environment* env)); | ||
| 849 | 847 | // Run `process.emit('exit')` as it would usually happen when Node.js is run | |
| 850 | 848 | // in standalone mode. The return value corresponds to the exit code. | |
| 851 | 849 | NODE_EXTERN v8::Maybe<int> EmitProcessExit(Environment* env); | |
| 852 | - NODE_DEPRECATED("Use Maybe version (EmitProcessExit) instead", | ||
| 853 | - NODE_EXTERN int EmitExit(Environment* env)); | ||
| 854 | 850 | ||
| 855 | 851 | // Runs hooks added through `AtExit()`. This is part of `FreeEnvironment()`, | |
| 856 | 852 | // so calling it manually is typically not necessary. | |
0 commit comments