FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

build: expose libplatform symbols in shared libnode · nodejs/node@56b1198 · GitHub

/ node Public

Commit 56b1198

Browse files
joyeecheung
authored and
juanarbol
committed
build: expose libplatform symbols in shared libnode
This requires setting BUILDING_V8_PLATFORM_SHARED to expose the public symbols since we build with hidden visibility by default. PR-URL: #61144 Fixes: #61102 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com>
1 parent 18ea303 commit 56b1198

2 files changed

Lines changed: 11 additions & 0 deletions

File tree

‎node.gypi‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,11 @@
5050
'defines': [
5151
'USING_UV_SHARED',
5252
'USING_V8_SHARED',
53+
'USING_V8_PLATFORM_SHARED',
5354
'BUILDING_NODE_EXTENSION'
5455
],
5556
'defines!': [
57+
'BUILDING_V8_PLATFORM_SHARED=1',
5658
'BUILDING_V8_SHARED=1',
5759
'BUILDING_UV_SHARED=1'
5860
]

‎tools/v8_gypfiles/v8.gyp‎

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -53,6 +53,7 @@
5353
['OS!="aix" and OS!="os400"', {
5454
'defines': [
5555
'BUILDING_V8_SHARED', # Make V8_EXPORT visible.
56+
'BUILDING_V8_PLATFORM_SHARED', # Make V8_PLATFORM_EXPORT visible.
5657
]
5758
}],
5859
['node_shared=="true"', {
@@ -1321,6 +1322,7 @@
13211322
['component=="shared_library"', {
13221323
'defines': [
13231324
'BUILDING_V8_SHARED',
1325+
'BUILDING_V8_PLATFORM_SHARED',
13241326
],
13251327
}],
13261328
['v8_enable_i18n_support==1', {
@@ -1398,6 +1400,7 @@
13981400
'defines!': [
13991401
'_HAS_EXCEPTIONS=0',
14001402
'BUILDING_V8_SHARED=1',
1403+
'BUILDING_V8_PLATFORM_SHARED=1',
14011404
],
14021405
'cflags_cc!': ['-fno-exceptions'],
14031406
'cflags_cc': ['-fexceptions'],
@@ -1424,6 +1427,7 @@
14241427
'defines!': [
14251428
'_HAS_EXCEPTIONS=0',
14261429
'BUILDING_V8_SHARED=1',
1430+
'BUILDING_V8_PLATFORM_SHARED=1',
14271431
],
14281432
'cflags_cc!': ['-fno-exceptions'],
14291433
'cflags_cc': ['-fexceptions'],
@@ -1794,6 +1798,7 @@
17941798
],
17951799
'defines!': [
17961800
'BUILDING_V8_SHARED=1',
1801+
'BUILDING_V8_PLATFORM_SHARED=1',
17971802
],
17981803
'dependencies': [
17991804
"v8_libbase",
@@ -1855,6 +1860,7 @@
18551860
'defines!': [
18561861
'_HAS_EXCEPTIONS=0',
18571862
'BUILDING_V8_SHARED=1',
1863+
'BUILDING_V8_PLATFORM_SHARED=1',
18581864
],
18591865
'cflags_cc!': ['-fno-exceptions'],
18601866
'cflags_cc': ['-fexceptions'],
@@ -1898,6 +1904,7 @@
18981904
'defines!': [
18991905
'_HAS_EXCEPTIONS=0',
19001906
'BUILDING_V8_SHARED=1',
1907+
'BUILDING_V8_PLATFORM_SHARED=1',
19011908
],
19021909
'msvs_settings': {
19031910
'VCCLCompilerTool': {
@@ -2130,10 +2137,12 @@
21302137
],
21312138
'defines': [
21322139
'BUILDING_V8_SHARED',
2140+
'BUILDING_V8_PLATFORM_SHARED',
21332141
],
21342142
'direct_dependent_settings': {
21352143
'defines': [
21362144
'USING_V8_SHARED',
2145+
'USING_V8_PLATFORM_SHARED',
21372146
],
21382147
},
21392148
'conditions': [

0 commit comments

Comments
 (0)
Back | FazBrowse Home | New Git URL