Revert "src: skip test_fatal/test_threads for Debug builds" · nodejs/node@570bef1 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 570bef1

Browse filesBrowse the repository at this point in the historyBrowse files

addaleax

authored and

BethGriggs

committed

Revert "src: skip test_fatal/test_threads for Debug builds"

This reverts commit 1fc4d43. PR-URL: #39954 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

1 parent 842f936 commit 570bef1
Copy full SHA for 570bef1

1 file changed

-4Lines changed: 0 additions & 4 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/node-api/test_fatal
  • test_threads.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/node-api/test_fatal/test_threads.js‎

Copy file name to clipboardExpand all lines: test/node-api/test_fatal/test_threads.js

-4Lines changed: 0 additions & 4 deletions

Original file line number	Diff line number	Diff line change
@@ -4,10 +4,6 @@ const assert = require('assert');
4	4	const child_process = require('child_process');
5	5	const test_fatal = require(`./build/${common.buildType}/test_fatal`);
6	6
7		- if (common.buildType === 'Debug')
8		- common.skip('as this will currently fail with a Debug check ' +
9		- 'in v8::Isolate::GetCurrent()');
10		-
11	7	// Test in a child process because the test code will trigger a fatal error
12	8	// that crashes the process.
13	9	if (process.argv[2] === 'child') {

0 commit comments

Comments

0 (0)