Commit 570d334
test: improvements in test fixtures symlinked
- using strictEqual instead equal
- common dependency should be the first one
- using path.join instead relative path
PR-URL: #10182
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>1 parent 6592a87 commit 570d334
1 file changed
Lines changed: 6 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -1,13 +1,13 @@ | |||
| 1 | 1 | 'use strict'; | |
| 2 | - const assert = require('assert'); | ||
| 3 | 2 | const common = require('../../common'); | |
| 3 | + const assert = require('assert'); | ||
| 4 | + const foo = require('./foo'); | ||
| 4 | 5 | const path = require('path'); | |
| 5 | 6 | ||
| 6 | 7 | const linkScriptTarget = path.join(common.fixturesDir, | |
| 7 | - '/module-require-symlink/symlinked.js'); | ||
| 8 | + 'module-require-symlink', 'symlinked.js'); | ||
| 8 | 9 | ||
| 9 | - var foo = require('./foo'); | ||
| 10 | - assert.equal(foo.dep1.bar.version, 'CORRECT_VERSION'); | ||
| 11 | - assert.equal(foo.dep2.bar.version, 'CORRECT_VERSION'); | ||
| 12 | - assert.equal(__filename, linkScriptTarget); | ||
| 10 | + assert.strictEqual(foo.dep1.bar.version, 'CORRECT_VERSION'); | ||
| 11 | + assert.strictEqual(foo.dep2.bar.version, 'CORRECT_VERSION'); | ||
| 12 | + assert.strictEqual(__filename, linkScriptTarget); | ||
| 13 | 13 | assert(__filename in require.cache); | |
0 commit comments