Commit 570de44
src: fix memory leak introduced in 34febfb
Fix leaking the BIO in the error path. Introduced in commit 34febfb
("crypto: fix handling of root_cert_store").
PR-URL: #9604
Refs: #9409
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rod Vagg <rod@vagg.org>1 parent f299333 commit 570de44
1 file changed
Lines changed: 1 addition & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -770,9 +770,8 @@ void SecureContext::AddCRL(const FunctionCallbackInfo<Value>& args) { | |||
| 770 | 770 | PEM_read_bio_X509_CRL(bio, nullptr, CryptoPemCallback, nullptr); | |
| 771 | 771 | ||
| 772 | 772 | if (crl == nullptr) { | |
| 773 | - return env->ThrowError("Failed to parse CRL"); | ||
| 774 | 773 | BIO_free_all(bio); | |
| 775 | - return; | ||
| 774 | + return env->ThrowError("Failed to parse CRL"); | ||
| 776 | 775 | } | |
| 777 | 776 | ||
| 778 | 777 | X509_STORE* cert_store = SSL_CTX_get_cert_store(sc->ctx_); | |
0 commit comments