Commit 574afac
src: check size of args before using for exec_path
If we are in an artifically created Environment that has no args set,
and uv_exepath returns an error (for instance, if /proc is not mounted
on a Linux system), then we crash with a nullptr deref attempting to
use argv[0].
Fixes: #45901
PR-URL: #45902
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent 7a97f3f commit 574afac
1 file changed
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -618,7 +618,7 @@ std::string GetExecPath(const std::vector<std::string>& argv) { | |||
| 618 | 618 | std::string exec_path; | |
| 619 | 619 | if (uv_exepath(exec_path_buf, &exec_path_len) == 0) { | |
| 620 | 620 | exec_path = std::string(exec_path_buf, exec_path_len); | |
| 621 | - } else { | ||
| 621 | + } else if (argv.size() > 0) { | ||
| 622 | 622 | exec_path = argv[0]; | |
| 623 | 623 | } | |
| 624 | 624 | ||
0 commit comments