Commit 575fc4e
gtest: output tap comments as yamlish
This makes yaml-ish parsers happy.
Note: gtest still seems to output the expected/result slightly
different making the full traceback less informational.
PR-URL: #9262
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Myles Borins <myles.borins@gmail.com>1 parent a643d3c commit 575fc4e
1 file changed
Lines changed: 9 additions & 7 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -3596,25 +3596,27 @@ void TapUnitTestResultPrinter::OutputTapTestInfo(int* count, | |||
| 3596 | 3596 | *stream << " ---\n"; | |
| 3597 | 3597 | *stream << " duration_ms: " << | |
| 3598 | 3598 | FormatTimeInMillisAsSeconds(result.elapsed_time()) << "\n"; | |
| 3599 | - *stream << " ...\n"; | ||
| 3600 | 3599 | ||
| 3601 | - for (int i = 0; i < result.total_part_count(); ++i) { | ||
| 3602 | - const TestPartResult& part = result.GetTestPartResult(i); | ||
| 3603 | - OutputTapComment(stream, part.message()); | ||
| 3600 | + if (result.total_part_count() > 0) { | ||
| 3601 | + *stream << " stack: |-\n"; | ||
| 3602 | + for (int i = 0; i < result.total_part_count(); ++i) { | ||
| 3603 | + const TestPartResult& part = result.GetTestPartResult(i); | ||
| 3604 | + OutputTapComment(stream, part.message()); | ||
| 3605 | + } | ||
| 3604 | 3606 | } | |
| 3605 | - | ||
| 3607 | + *stream << " ...\n"; | ||
| 3606 | 3608 | *count += 1; | |
| 3607 | 3609 | } | |
| 3608 | 3610 | ||
| 3609 | 3611 | void TapUnitTestResultPrinter::OutputTapComment(::std::ostream* stream, | |
| 3610 | 3612 | const char* comment) { | |
| 3611 | 3613 | const char* start = comment; | |
| 3612 | 3614 | while (const char* end = strchr(start, '\n')) { | |
| 3613 | - *stream << "# " << std::string(start, end) << "\n"; | ||
| 3615 | + *stream << " " << std::string(start, end) << "\n"; | ||
| 3614 | 3616 | start = end + 1; | |
| 3615 | 3617 | } | |
| 3616 | 3618 | if (*start) | |
| 3617 | - *stream << "# " << start << "\n"; | ||
| 3619 | + *stream << " " << start << "\n"; | ||
| 3618 | 3620 | } | |
| 3619 | 3621 | ||
| 3620 | 3622 | // Formats the given time in milliseconds as seconds. | |
0 commit comments