Commit 5796631
node-api: avoid macro redefinition
Even though the redefinition complies with the C standard because the
second definition is "effectively the same" as the first definition,
it's best to avoid any redefinition.
Refs: #28237
Refs: #30006
PR-URL: #48879
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Vladimir Morozov <vmorozov@microsoft.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>1 parent 67dba57 commit 5796631
1 file changed
Lines changed: 0 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -268,14 +268,6 @@ inline napi_status napi_set_last_error(napi_env env, | |||
| 268 | 268 | } \ | |
| 269 | 269 | } while (0) | |
| 270 | 270 | ||
| 271 | - #define RETURN_STATUS_IF_FALSE_WITH_PREAMBLE(env, condition, status) \ | ||
| 272 | - do { \ | ||
| 273 | - if (!(condition)) { \ | ||
| 274 | - return napi_set_last_error( \ | ||
| 275 | - (env), try_catch.HasCaught() ? napi_pending_exception : (status)); \ | ||
| 276 | - } \ | ||
| 277 | - } while (0) | ||
| 278 | - | ||
| 279 | 271 | #define CHECK_MAYBE_EMPTY_WITH_PREAMBLE(env, maybe, status) \ | |
| 280 | 272 | RETURN_STATUS_IF_FALSE_WITH_PREAMBLE((env), !((maybe).IsEmpty()), (status)) | |
| 281 | 273 | ||
0 commit comments