Commit 579e066
crypto: add digest name to INVALID_DIGEST errors
We already do this in some places. This adds the digest name to
remaining uses of ERR_CRYPTO_INVALID_DIGEST except for one occurrence in
crypto_sig.cc that would require significant refactoring due to the
unusual error handling there.
PR-URL: #44468
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>1 parent d76e7e4 commit 579e066
4 files changed
Lines changed: 6 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -58,7 +58,7 @@ Maybe<bool> HKDFTraits::AdditionalConfig( | |||
| 58 | 58 | Utf8Value hash(env->isolate(), args[offset]); | |
| 59 | 59 | params->digest = EVP_get_digestbyname(*hash); | |
| 60 | 60 | if (params->digest == nullptr) { | |
| 61 | - THROW_ERR_CRYPTO_INVALID_DIGEST(env); | ||
| 61 | + THROW_ERR_CRYPTO_INVALID_DIGEST(env, "Invalid digest: %s", *hash); | ||
| 62 | 62 | return Nothing<bool>(); | |
| 63 | 63 | } | |
| 64 | 64 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -70,7 +70,8 @@ void Hmac::HmacInit(const char* hash_type, const char* key, int key_len) { | |||
| 70 | 70 | ||
| 71 | 71 | const EVP_MD* md = EVP_get_digestbyname(hash_type); | |
| 72 | 72 | if (md == nullptr) | |
| 73 | - return THROW_ERR_CRYPTO_INVALID_DIGEST(env()); | ||
| 73 | + return THROW_ERR_CRYPTO_INVALID_DIGEST( | ||
| 74 | + env(), "Invalid digest: %s", hash_type); | ||
| 74 | 75 | if (key_len == 0) { | |
| 75 | 76 | key = ""; | |
| 76 | 77 | } | |
@@ -187,7 +188,7 @@ Maybe<bool> HmacTraits::AdditionalConfig( | |||
| 187 | 188 | Utf8Value digest(env->isolate(), args[offset + 1]); | |
| 188 | 189 | params->digest = EVP_get_digestbyname(*digest); | |
| 189 | 190 | if (params->digest == nullptr) { | |
| 190 | - THROW_ERR_CRYPTO_INVALID_DIGEST(env); | ||
| 191 | + THROW_ERR_CRYPTO_INVALID_DIGEST(env, "Invalid digest: %s", *digest); | ||
| 191 | 192 | return Nothing<bool>(); | |
| 192 | 193 | } | |
| 193 | 194 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -333,7 +333,7 @@ Maybe<bool> RSACipherTraits::AdditionalConfig( | |||
| 333 | 333 | ||
| 334 | 334 | params->digest = EVP_get_digestbyname(*digest); | |
| 335 | 335 | if (params->digest == nullptr) { | |
| 336 | - THROW_ERR_CRYPTO_INVALID_DIGEST(env); | ||
| 336 | + THROW_ERR_CRYPTO_INVALID_DIGEST(env, "Invalid digest: %s", *digest); | ||
| 337 | 337 | return Nothing<bool>(); | |
| 338 | 338 | } | |
| 339 | 339 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -648,7 +648,7 @@ Maybe<bool> SignTraits::AdditionalConfig( | |||
| 648 | 648 | Utf8Value digest(env->isolate(), args[offset + 6]); | |
| 649 | 649 | params->digest = EVP_get_digestbyname(*digest); | |
| 650 | 650 | if (params->digest == nullptr) { | |
| 651 | - THROW_ERR_CRYPTO_INVALID_DIGEST(env); | ||
| 651 | + THROW_ERR_CRYPTO_INVALID_DIGEST(env, "Invalid digest: %s", *digest); | ||
| 652 | 652 | return Nothing<bool>(); | |
| 653 | 653 | } | |
| 654 | 654 | } | |
0 commit comments