Commit 57ae876
crypto: fix warnings in test_node_crypto.cc
Fix build warnings by casting the number literals to the size_t
constants they are compared against.
Signed-off-by: Maya Lekova <maya@igalia.com>
PR-URL: #63490
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: René <contact.9a5d6388@renegade334.me.uk>1 parent 066fff1 commit 57ae876
1 file changed
Lines changed: 9 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -31,25 +31,25 @@ TEST(NodeCrypto, NewRootCertStore) { | |||
| 31 | 31 | */ | |
| 32 | 32 | TEST(NodeCrypto, MemoryTrackingConstants) { | |
| 33 | 33 | // Verify that our memory tracking constants are defined and reasonable | |
| 34 | - EXPECT_GT(node::crypto::kSizeOf_SSL_CTX, 0) | ||
| 34 | + EXPECT_GT(node::crypto::kSizeOf_SSL_CTX, static_cast<size_t>(0)) | ||
| 35 | 35 | << "SSL_CTX size constant should be positive"; | |
| 36 | - EXPECT_GT(node::crypto::kSizeOf_X509, 0) | ||
| 36 | + EXPECT_GT(node::crypto::kSizeOf_X509, static_cast<size_t>(0)) | ||
| 37 | 37 | << "X509 size constant should be positive"; | |
| 38 | - EXPECT_GT(node::crypto::kSizeOf_EVP_MD_CTX, 0) | ||
| 38 | + EXPECT_GT(node::crypto::kSizeOf_EVP_MD_CTX, static_cast<size_t>(0)) | ||
| 39 | 39 | << "EVP_MD_CTX size constant should be positive"; | |
| 40 | 40 | ||
| 41 | 41 | // Verify reasonable size ranges (basic sanity check) | |
| 42 | - EXPECT_LT(node::crypto::kSizeOf_SSL_CTX, 10000) | ||
| 42 | + EXPECT_LT(node::crypto::kSizeOf_SSL_CTX, static_cast<size_t>(10000)) | ||
| 43 | 43 | << "SSL_CTX size should be reasonable"; | |
| 44 | - EXPECT_LT(node::crypto::kSizeOf_X509, 10000) | ||
| 44 | + EXPECT_LT(node::crypto::kSizeOf_X509, static_cast<size_t>(10000)) | ||
| 45 | 45 | << "X509 size should be reasonable"; | |
| 46 | - EXPECT_LT(node::crypto::kSizeOf_EVP_MD_CTX, 1000) | ||
| 46 | + EXPECT_LT(node::crypto::kSizeOf_EVP_MD_CTX, static_cast<size_t>(1000)) | ||
| 47 | 47 | << "EVP_MD_CTX size should be reasonable"; | |
| 48 | 48 | ||
| 49 | 49 | // Specific values we expect based on our implementation | |
| 50 | - EXPECT_EQ(node::crypto::kSizeOf_SSL_CTX, 240); | ||
| 51 | - EXPECT_EQ(node::crypto::kSizeOf_X509, 128); | ||
| 52 | - EXPECT_EQ(node::crypto::kSizeOf_EVP_MD_CTX, 48); | ||
| 50 | + EXPECT_EQ(node::crypto::kSizeOf_SSL_CTX, static_cast<size_t>(240)); | ||
| 51 | + EXPECT_EQ(node::crypto::kSizeOf_X509, static_cast<size_t>(128)); | ||
| 52 | + EXPECT_EQ(node::crypto::kSizeOf_EVP_MD_CTX, static_cast<size_t>(48)); | ||
| 53 | 53 | } | |
| 54 | 54 | ||
| 55 | 55 | TEST(NodeCrypto, TryGetIntCipherOutputLength) { | |
0 commit comments