FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: skip stringbytes-external-exceed-max on AIX · nodejs/node@588b761 · GitHub

/ node Public

Commit 588b761

Browse files
sam-github
authored and
BethGriggs
committed
test: skip stringbytes-external-exceed-max on AIX
Add SKIP status for more tests in stringbytes-external-exceed-max that are failing on AIX. PR-URL: #28516 Backport-PR-URL: #29599 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
1 parent 930647d commit 588b761

2 files changed

Lines changed: 19 additions & 5 deletions

File tree

‎test/addons/addon.status‎

Lines changed: 19 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,19 @@
1+
prefix addons
2+
3+
[true] # This section applies to all platforms
4+
5+
[$system==aix]
6+
# https://github.com/nodejs/build/issues/1820#issuecomment-505998851
7+
# https://github.com/nodejs/node/pull/28469
8+
# https://github.com/nodejs/node/pull/28516
9+
stringbytes-external-exceed-max/test-stringbytes-external-exceed-max.js: SKIP
10+
11+
# https://github.com/nodejs/node/pull/28516
12+
stringbytes-external-exceed-max/test-stringbytes-external-at-max: SKIP
13+
stringbytes-external-exceed-max/test-stringbytes-external-exceed-max-by-1-ascii: SKIP
14+
stringbytes-external-exceed-max/test-stringbytes-external-exceed-max-by-1-base64: SKIP
15+
stringbytes-external-exceed-max/test-stringbytes-external-exceed-max-by-1-binary: SKIP
16+
stringbytes-external-exceed-max/test-stringbytes-external-exceed-max-by-1-hex: SKIP
17+
stringbytes-external-exceed-max/test-stringbytes-external-exceed-max-by-1-utf8: SKIP
18+
stringbytes-external-exceed-max/test-stringbytes-external-exceed-max-by-2: SKIP
19+
stringbytes-external-exceed-max/test-stringbytes-external-exceed-max: SKIP

‎test/addons/stringbytes-external-exceed-max/test-stringbytes-external-exceed-max.js‎

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -5,11 +5,6 @@ const skipMessage = 'intensive toString tests due to memory confinements';
55
if (!common.enoughTestMem)
66
common.skip(skipMessage);
77

8-
// See https://github.com/nodejs/build/issues/1820#issuecomment-505998851
9-
// See https://github.com/nodejs/node/pull/28469
10-
if (process.platform === 'aix')
11-
common.skip('flaky on AIX');
12-
138
const binding = require(`./build/${common.buildType}/binding`);
149
const assert = require('assert');
1510

0 commit comments

Comments
 (0)
Back | FazBrowse Home | New Git URL