Commit 5905596
test: fix incorrect test fixture
This commit updates a test runner fixture that includes a failing
child test. However, the nested test is created using the top
level test() function instead t.test(). This commit updates the
fixture to use t.test(), while preserving the expected failure.
Refs: #47164
PR-URL: #52185
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>1 parent bae14b7 commit 5905596
2 files changed
Lines changed: 15 additions & 3 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -9,7 +9,9 @@ const test = require('node:test'); | |||
| 9 | 9 | test('should pass', () => {}); | |
| 10 | 10 | test('should fail', () => { throw new Error('fail'); }); | |
| 11 | 11 | test('should skip', { skip: true }, () => {}); | |
| 12 | - test('parent', () => { | ||
| 13 | - test('should fail', () => { throw new Error('fail'); }); | ||
| 14 | - test('should pass but parent fail', () => {}); | ||
| 12 | + test('parent', (t) => { | ||
| 13 | + t.test('should fail', () => { throw new Error('fail'); }); | ||
| 14 | + t.test('should pass but parent fail', (t, done) => { | ||
| 15 | + setImmediate(done); | ||
| 16 | + }); | ||
| 15 | 17 | }); | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -17,6 +17,11 @@ | |||
| 17 | 17 | *[39m | |
| 18 | 18 | *[39m | |
| 19 | 19 | *[39m | |
| 20 | + *[39m | ||
| 21 | + *[39m | ||
| 22 | + *[39m | ||
| 23 | + *[39m | ||
| 24 | + *[39m | ||
| 20 | 25 | *[39m | |
| 21 | 26 | ||
| 22 | 27 | [31m✖ should pass but parent fail [90m(*ms)[39m[39m | |
@@ -53,6 +58,11 @@ | |||
| 53 | 58 | *[39m | |
| 54 | 59 | *[39m | |
| 55 | 60 | *[39m | |
| 61 | + *[39m | ||
| 62 | + *[39m | ||
| 63 | + *[39m | ||
| 64 | + *[39m | ||
| 65 | + *[39m | ||
| 56 | 66 | *[39m | |
| 57 | 67 | ||
| 58 | 68 | * | |
0 commit comments