test: avoid deadlock issue in pipeline http2 tests to fix flakiness · nodejs/node@59d7e22 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 757
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit 59d7e22

Browse filesBrowse the repository at this point in the historyBrowse files

authored and

aduh95

committed

test: avoid deadlock issue in pipeline http2 tests to fix flakiness

This does not solve the remaining underlying deadlock issue, but does bound the test behaviour in a way that seems to avoid failures in practice. Deadlock fix to come separately later. Co-authored-by: Filip Skokan <panva.ip@gmail.com> Signed-off-by: Tim Perry <pimterry@gmail.com> PR-URL: #65079 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com>

1 parent 7074ae3 commit 59d7e22
Copy full SHA for 59d7e22

1 file changed

+5-3Lines changed: 5 additions & 3 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/parallel
  • test-stream-pipeline-http2.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/parallel/test-stream-pipeline-http2.js‎

Copy file name to clipboardExpand all lines: test/parallel/test-stream-pipeline-http2.js

+5-3Lines changed: 5 additions & 3 deletions

Original file line number	Diff line number	Diff line change
@@ -27,10 +27,12 @@ const http2 = require('http2');
27	27	client.close();
28	28	}));
29	29
30		- let cnt = 10;
	30	+ let received = 0;
31	31	req.on('data', (data) => {
32		- cnt--;
33		- if (cnt === 0) rs.destroy();
	32	+ received += data.length;
	33	+ // Bound the data that flows before teardown - bytes per data event vary
	34	+ // by platform, and letting this run longer hangs on macOS.
	35	+ if (received >= 32 * 1024) rs.destroy();
34	36	});
35	37	}));
36	38	}

0 commit comments

Comments

0 (0)