Commit 59e6f62
committed
deps: disable V8 concurrent sparkplug compilation
It introduces process hangs on some platforms because Node.js doesn't
tear down V8 correctly.
Disable it while we work on a solution.
Refs: #47297
Refs: https://bugs.chromium.org/p/v8/issues/detail?id=13902
PR-URL: #47450
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #51362
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>1 parent 0423f7e commit 59e6f62
2 files changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -37,7 +37,7 @@ | |||
| 37 | 37 | ||
| 38 | 38 | # Reset this number to 0 on major V8 upgrades. | |
| 39 | 39 | # Increment by one for each non-official patch applied to deps/v8. | |
| 40 | - 'v8_embedder_string': '-node.2', | ||
| 40 | + 'v8_embedder_string': '-node.3', | ||
| 41 | 41 | ||
| 42 | 42 | ##### V8 defaults for Node.js ##### | |
| 43 | 43 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -936,7 +936,7 @@ DEFINE_BOOL(baseline_batch_compilation, true, "batch compile Sparkplug code") | |||
| 936 | 936 | DEFINE_BOOL_READONLY(concurrent_sparkplug, false, | |
| 937 | 937 | "compile Sparkplug code in a background thread") | |
| 938 | 938 | #else | |
| 939 | - DEFINE_BOOL(concurrent_sparkplug, ENABLE_SPARKPLUG_BY_DEFAULT, | ||
| 939 | + DEFINE_BOOL(concurrent_sparkplug, false, | ||
| 940 | 940 | "compile Sparkplug code in a background thread") | |
| 941 | 941 | DEFINE_WEAK_IMPLICATION(future, concurrent_sparkplug) | |
| 942 | 942 | DEFINE_NEG_IMPLICATION(predictable, concurrent_sparkplug) | |
0 commit comments