Commit 5ab3ca4
url: declare iterator inside loop
Refs: #30281 (comment)
PR-URL: #30509
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>1 parent 5f42b1f commit 5ab3ca4
1 file changed
Lines changed: 3 additions & 4 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -166,8 +166,7 @@ Url.prototype.parse = function parse(url, parseQueryString, slashesDenoteHost) { | |||
| 166 | 166 | let end = -1; | |
| 167 | 167 | let rest = ''; | |
| 168 | 168 | let lastPos = 0; | |
| 169 | - let i = 0; | ||
| 170 | - for (let inWs = false, split = false; i < url.length; ++i) { | ||
| 169 | + for (let i = 0, inWs = false, split = false; i < url.length; ++i) { | ||
| 171 | 170 | const code = url.charCodeAt(i); | |
| 172 | 171 | ||
| 173 | 172 | // Find first and last non-whitespace characters for trimming | |
@@ -299,7 +298,7 @@ Url.prototype.parse = function parse(url, parseQueryString, slashesDenoteHost) { | |||
| 299 | 298 | let hostEnd = -1; | |
| 300 | 299 | let atSign = -1; | |
| 301 | 300 | let nonHost = -1; | |
| 302 | - for (i = 0; i < rest.length; ++i) { | ||
| 301 | + for (let i = 0; i < rest.length; ++i) { | ||
| 303 | 302 | switch (rest.charCodeAt(i)) { | |
| 304 | 303 | case CHAR_TAB: | |
| 305 | 304 | case CHAR_LINE_FEED: | |
@@ -415,7 +414,7 @@ Url.prototype.parse = function parse(url, parseQueryString, slashesDenoteHost) { | |||
| 415 | 414 | ||
| 416 | 415 | let questionIdx = -1; | |
| 417 | 416 | let hashIdx = -1; | |
| 418 | - for (i = 0; i < rest.length; ++i) { | ||
| 417 | + for (let i = 0; i < rest.length; ++i) { | ||
| 419 | 418 | const code = rest.charCodeAt(i); | |
| 420 | 419 | if (code === CHAR_HASH) { | |
| 421 | 420 | this.hash = rest.slice(i); | |
0 commit comments