Commit 5ab4471
build,tools: do not force codesign prefix
Allow passing the prefix in via the PKGDIR env var. This will allow us
to use this same script to codesign the binary tarball.
PR-URL: #14179
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>1 parent def98c6 commit 5ab4471
2 files changed
Lines changed: 3 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -702,7 +702,8 @@ $(PKG): release-only | |||
| 702 | 702 | --release-urlbase=$(RELEASE_URLBASE) \ | |
| 703 | 703 | $(CONFIG_FLAGS) $(BUILD_RELEASE_FLAGS) | |
| 704 | 704 | $(MAKE) install V=$(V) DESTDIR=$(PKGDIR) | |
| 705 | - SIGN="$(CODESIGN_CERT)" PKGDIR="$(PKGDIR)" bash tools/osx-codesign.sh | ||
| 705 | + SIGN="$(CODESIGN_CERT)" PKGDIR="$(PKGDIR)/usr/local" bash \ | ||
| 706 | + tools/osx-codesign.sh | ||
| 706 | 707 | cat tools/osx-pkg.pmdoc/index.xml.tmpl \ | |
| 707 | 708 | | sed -E "s/\\{nodeversion\\}/$(FULLVERSION)/g" \ | |
| 708 | 709 | | sed -E "s/\\{npmversion\\}/$(NPMVERSION)/g" \ | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -8,4 +8,4 @@ if [ "X$SIGN" == "X" ]; then | |||
| 8 | 8 | exit 0 | |
| 9 | 9 | fi | |
| 10 | 10 | ||
| 11 | - codesign -s "$SIGN" "$PKGDIR"/usr/local/bin/node | ||
| 11 | + codesign -s "$SIGN" "$PKGDIR"/bin/node | ||
0 commit comments