Commit 5b240c6
committed
deps: always define V8_EXPORT_PRIVATE as no-op
dllexport introduces issues when compiling with MSVC.
PR-URL: #47251
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
PR-URL: #49639
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: #50115
Reviewed-By: Michael Dawson <midawson@redhat.com>1 parent 2cff0ce commit 5b240c6
2 files changed
Lines changed: 5 additions & 5 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -36,7 +36,7 @@ | |||
| 36 | 36 | ||
| 37 | 37 | # Reset this number to 0 on major V8 upgrades. | |
| 38 | 38 | # Increment by one for each non-official patch applied to deps/v8. | |
| 39 | - 'v8_embedder_string': '-node.0', | ||
| 39 | + 'v8_embedder_string': '-node.1', | ||
| 40 | 40 | ||
| 41 | 41 | ##### V8 defaults for Node.js ##### | |
| 42 | 42 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -389,9 +389,9 @@ bool is_inbounds(float_t v) { | |||
| 389 | 389 | // Setup for Windows shared library export. | |
| 390 | 390 | #define V8_EXPORT_ENUM | |
| 391 | 391 | #ifdef BUILDING_V8_SHARED | |
| 392 | - #define V8_EXPORT_PRIVATE __declspec(dllexport) | ||
| 392 | + #define V8_EXPORT_PRIVATE | ||
| 393 | 393 | #elif USING_V8_SHARED | |
| 394 | - #define V8_EXPORT_PRIVATE __declspec(dllimport) | ||
| 394 | + #define V8_EXPORT_PRIVATE | ||
| 395 | 395 | #else | |
| 396 | 396 | #define V8_EXPORT_PRIVATE | |
| 397 | 397 | #endif // BUILDING_V8_SHARED | |
@@ -401,8 +401,8 @@ bool is_inbounds(float_t v) { | |||
| 401 | 401 | // Setup for Linux shared library export. | |
| 402 | 402 | #if V8_HAS_ATTRIBUTE_VISIBILITY | |
| 403 | 403 | #ifdef BUILDING_V8_SHARED | |
| 404 | - #define V8_EXPORT_PRIVATE __attribute__((visibility("default"))) | ||
| 405 | - #define V8_EXPORT_ENUM V8_EXPORT_PRIVATE | ||
| 404 | + #define V8_EXPORT_PRIVATE | ||
| 405 | + #define V8_EXPORT_ENUM | ||
| 406 | 406 | #else | |
| 407 | 407 | #define V8_EXPORT_PRIVATE | |
| 408 | 408 | #define V8_EXPORT_ENUM | |
0 commit comments