Commit 5b5e07a
committed
meta: update label-pr-config
- Rename "ES Modules" label to "esm" (This already happened on GitHub
a while ago).
- Add missing "fast-track" to deps/npm (It was lost when the pull
request adding it landed).
- Rename "intl" to "i18n-api" (There is no intl label).
- Rename "url-whatwg" to "whatwg-url".
- Rename "V8 Engine" to "v8 engine".
- Rename "n-api" to "node-api".
- Add "python" to .py files.
- Add "gyp" to tools/gyp.
- Add "icu" to tools/icu.
- Add "tools" and "v8 engine" to tools/v8_gypfiles.
- Add "release" to doc/changelogs.
PR-URL: #38950
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>1 parent 08b2a4a commit 5b5e07a
1 file changed
Lines changed: 25 additions & 25 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -11,22 +11,22 @@ subSystemLabels: | |||
| 11 | 11 | /^src\/udp_/: c++, dgram | |
| 12 | 12 | /^src\/(?:fs_|node_file|node_stat_watcher)/: c++, fs | |
| 13 | 13 | /^src\/node_http_parser/: c++, http_parser | |
| 14 | - /^src\/node_i18n/: c++, intl | ||
| 14 | + /^src\/node_i18n/: c++, i18n-api | ||
| 15 | 15 | /^src\/uv\./: c++, libuv | |
| 16 | 16 | /^src\/(?:connect(?:ion)?|pipe|tcp)_/: c++, net | |
| 17 | 17 | /^src\/node_os/: c++, os | |
| 18 | 18 | /^src\/(?:node_main|signal_)/: c++, process | |
| 19 | 19 | /^src\/timer_/: c++, timers | |
| 20 | 20 | /^src\/(?:CNNICHashWhitelist|node_root_certs|tls_)/: c++, tls | |
| 21 | 21 | /^src\/tty_/: c++, tty | |
| 22 | - /^src\/node_url/: c++, url-whatwg | ||
| 22 | + /^src\/node_url/: c++, whatwg-url | ||
| 23 | 23 | /^src\/node_util/: c++, util | |
| 24 | - /^src\/(?:node_v8|v8abbr)/: c++, V8 Engine | ||
| 24 | + /^src\/(?:node_v8|v8abbr)/: c++, v8 engine | ||
| 25 | 25 | /^src\/node_contextify/: c++, vm | |
| 26 | 26 | /^src\/.*win32.*/: c++, windows | |
| 27 | 27 | /^src\/node_zlib/: c++, zlib | |
| 28 | 28 | /^src\/tracing/: c++, tracing | |
| 29 | - /^src\/node_api/: c++, n-api | ||
| 29 | + /^src\/node_api/: c++, node-api | ||
| 30 | 30 | /^src\/node_http2/: c++, http2 | |
| 31 | 31 | /^src\/node_report/: c++, report | |
| 32 | 32 | /^src\/node_wasi/: c++, wasi | |
@@ -35,7 +35,7 @@ subSystemLabels: | |||
| 35 | 35 | /^src\/node_bob*/: c++, quic, dont-land-on-v14.x, dont-land-on-v12.x | |
| 36 | 36 | ||
| 37 | 37 | # don't label python files as c++ | |
| 38 | - /^src\/.+\.py$/: lib / src, needs-ci | ||
| 38 | + /^src\/.+\.py$/: python, needs-ci | ||
| 39 | 39 | ||
| 40 | 40 | # properly label changes to v8 inspector integration-related files | |
| 41 | 41 | /^src\/inspector_/: c++, inspector, needs-ci | |
@@ -50,23 +50,24 @@ subSystemLabels: | |||
| 50 | 50 | /^\w+\.md$/: doc | |
| 51 | 51 | # different variants of *Makefile and build files | |
| 52 | 52 | /^(tools\/)?(Makefile|BSDmakefile|create_android_makefiles|\.travis\.yml)$/: build, needs-ci | |
| 53 | - /^tools\/(install\.py|genv8constants\.py|getnodeversion\.py|js2c\.py|utils\.py|configure\.d\/.*)$/: build, needs-ci | ||
| 53 | + /^tools\/(install\.py|genv8constants\.py|getnodeversion\.py|js2c\.py|utils\.py|configure\.d\/.*)$/: build, python, needs-ci | ||
| 54 | 54 | /^vcbuild\.bat$/: build, windows, needs-ci | |
| 55 | 55 | /^(android-)?configure|node\.gyp|common\.gypi$/: build, needs-ci | |
| 56 | 56 | # more specific tools | |
| 57 | - /^tools\/gyp/: tools, build, needs-ci, dont-land-on-v14.x, dont-land-on-v12.x | ||
| 57 | + /^tools\/gyp/: tools, build, gyp, needs-ci, dont-land-on-v14.x, dont-land-on-v12.x | ||
| 58 | 58 | /^tools\/doc\//: tools, doc | |
| 59 | - /^tools\/icu\//: tools, intl, needs-ci | ||
| 59 | + /^tools\/icu\//: tools, i18n-api, icu, needs-ci | ||
| 60 | 60 | /^tools\/(?:osx-pkg\.pmdoc|pkgsrc)\//: tools, macos, install | |
| 61 | 61 | /^tools\/(?:(?:mac)?osx-)/: tools, macos | |
| 62 | 62 | /^tools\/test-npm/: tools, test, npm | |
| 63 | 63 | /^tools\/test/: tools, test | |
| 64 | 64 | /^tools\/(?:certdata|mkssldef|mk-ca-bundle)/: tools, openssl, tls | |
| 65 | 65 | /^tools\/msvs\//: tools, windows, install, needs-ci | |
| 66 | 66 | /^tools\/[^/]+\.bat$/: tools, windows, needs-ci | |
| 67 | - /^tools\/make-v8/: tools, V8 Engine, needs-ci | ||
| 68 | - /^tools\/(code_cache|snapshot|v8_gypfiles)/: needs-ci, | ||
| 69 | - /^tools\/build-addons.js/: needs-ci, | ||
| 67 | + /^tools\/make-v8/: tools, v8 engine, needs-ci | ||
| 68 | + /^tools\/v8_gypfiles/: tools, v8 engine, needs-ci | ||
| 69 | + /^tools\/(code_cache|snapshot)/: needs-ci | ||
| 70 | + /^tools\/build-addons.js/: needs-ci | ||
| 70 | 71 | # all other tool changes should be marked as such | |
| 71 | 72 | /^tools\//: tools | |
| 72 | 73 | /^\.eslint|\.remark|\.editorconfig/: tools | |
@@ -75,10 +76,10 @@ subSystemLabels: | |||
| 75 | 76 | # libuv needs an explicit mapping, as the ordinary /deps/ mapping below would | |
| 76 | 77 | # end up as libuv changes labeled with "uv" (which is a non-existing label) | |
| 77 | 78 | /^deps\/uv\//: libuv | |
| 78 | - /^deps\/v8\/tools\/gen-postmortem-metadata\.py/: V8 Engine, post-mortem | ||
| 79 | - /^deps\/v8\//: V8 Engine | ||
| 79 | + /^deps\/v8\/tools\/gen-postmortem-metadata\.py/: v8 engine, python, post-mortem | ||
| 80 | + /^deps\/v8\//: v8 engine | ||
| 80 | 81 | /^deps\/uvwasi\//: wasi | |
| 81 | - /^deps\/npm\//: npm, dont-land-on-v14.x, dont-land-on-v12.x | ||
| 82 | + /^deps\/npm\//: npm, fast-track, dont-land-on-v14.x, dont-land-on-v12.x | ||
| 82 | 83 | /^deps\/nghttp2\/nghttp2\.gyp/: build, http2 | |
| 83 | 84 | /^deps\/nghttp2\//: http2 | |
| 84 | 85 | /^deps\/ngtcp2\//: quic, dont-land-on-v14.x, dont-land-on-v12.x | |
@@ -97,8 +98,8 @@ subSystemLabels: | |||
| 97 | 98 | /^lib\/\w+\/streams$/: stream | |
| 98 | 99 | /^lib\/.*http2/: http2 | |
| 99 | 100 | /^lib\/worker_threads.js$/: worker | |
| 100 | - /^lib\/internal\/url\.js$/: url-whatwg | ||
| 101 | - /^lib\/internal\/modules\/esm/: ES Modules | ||
| 101 | + /^lib\/internal\/url\.js$/: whatwg-url | ||
| 102 | + /^lib\/internal\/modules\/esm/: esm | ||
| 102 | 103 | /^lib\/internal\/quic\/*/: quic, dont-land-on-v14.x, dont-land-on-v12.x | |
| 103 | 104 | ||
| 104 | 105 | # All other lib/ files map directly | |
@@ -115,24 +116,22 @@ exlusiveLabels: | |||
| 115 | 116 | /^test\/pseudo-tty\//: test, tty | |
| 116 | 117 | /^test\/inspector\//: test, inspector | |
| 117 | 118 | /^test\/cctest\/test_inspector/: test, inspector | |
| 118 | - /^test\/cctest\/test_url/: test, url-whatwg | ||
| 119 | - /^test\/addons-napi\//: test, n-api | ||
| 119 | + /^test\/cctest\/test_url/: test, whatwg-url | ||
| 120 | + /^test\/addons-napi\//: test, node-api | ||
| 120 | 121 | /^test\/async-hooks\//: test, async_hooks | |
| 121 | 122 | /^test\/report\//: test, report | |
| 122 | - /^test\/fixtures\/es-module/: test, ES Modules | ||
| 123 | - /^test\/es-module\//: test, ES Modules | ||
| 123 | + /^test\/fixtures\/es-module/: test, esm | ||
| 124 | + /^test\/es-module\//: test, esm | ||
| 124 | 125 | ||
| 125 | 126 | /^test\//: test | |
| 126 | 127 | ||
| 127 | 128 | # specific map for webcrypto.md as it should be labeled 'crypto' | |
| 128 | 129 | /^doc\/api\/webcrypto.md$/: doc, crypto | |
| 129 | 130 | # specific map for modules.md as it should be labeled 'module' not 'modules' | |
| 130 | 131 | /^doc\/api\/modules.md$/: doc, module | |
| 131 | - # specific map for esm.md as it should be labeled 'ES Modules' not 'esm' | ||
| 132 | - /^doc\/api\/esm.md$/: doc, ES Modules | ||
| 133 | - # n-api is treated separately since it is not a JS core module but is still | ||
| 132 | + # node-api is treated separately since it is not a JS core module but is still | ||
| 134 | 133 | # considered a subsystem of sorts | |
| 135 | - /^doc\/api\/n-api.md$/: doc, n-api | ||
| 134 | + /^doc\/api\/n-api.md$/: doc, node-api | ||
| 136 | 135 | # quic | |
| 137 | 136 | /^doc\/api\/quic.md$/: doc, quic, dont-land-on-v14.x, dont-land-on-v12.x | |
| 138 | 137 | # add worker label to PRs that affect doc/api/worker_threads.md | |
@@ -141,12 +140,13 @@ exlusiveLabels: | |||
| 141 | 140 | /^doc\/api\/(\w+)\.md$/: doc, $1 | |
| 142 | 141 | # add deprecations label to PRs that affect doc/api/deprecations.md | |
| 143 | 142 | /^doc\/api\/deprecations.md$/: doc, deprecations | |
| 143 | + /^doc\/changelogs\//: release | ||
| 144 | 144 | ||
| 145 | 145 | /^doc\//: doc | |
| 146 | 146 | ||
| 147 | 147 | # more specific benchmarks | |
| 148 | 148 | /^benchmark\/buffers\//: benchmark, buffer | |
| 149 | - /^benchmark\/(?:arrays|es)\//: benchmark, V8 Engine | ||
| 149 | + /^benchmark\/(?:arrays|es)\//: benchmark, v8 engine | ||
| 150 | 150 | /^benchmark\/_http/: benchmark, http | |
| 151 | 151 | /^benchmark\/(?:misc|fixtures)\//: benchmark | |
| 152 | 152 | /^benchmark\/streams\//: benchmark, stream | |
0 commit comments