Commit 5bfefa6
lib: change == to === in linkedlist
Also removed a TODO comment that is no longer viable and left a note
about the potentially confusing property naming convention for future
readers.
PR-URL: #9362
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>1 parent 071836a commit 5bfefa6
1 file changed
Lines changed: 2 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -16,7 +16,7 @@ exports.create = create; | |||
| 16 | 16 | ||
| 17 | 17 | // show the most idle item | |
| 18 | 18 | function peek(list) { | |
| 19 | - if (list._idlePrev == list) return null; | ||
| 19 | + if (list._idlePrev === list) return null; | ||
| 20 | 20 | return list._idlePrev; | |
| 21 | 21 | } | |
| 22 | 22 | exports.peek = peek; | |
@@ -54,7 +54,7 @@ function append(list, item) { | |||
| 54 | 54 | } | |
| 55 | 55 | ||
| 56 | 56 | // items are linked with _idleNext -> (older) and _idlePrev -> (newer) | |
| 57 | - // TODO: swap the linkage to match the intuitive older items at "prev" | ||
| 57 | + // Note: This linkage (next being older) may seem counter-intuitive at first. | ||
| 58 | 58 | item._idleNext = list._idleNext; | |
| 59 | 59 | item._idlePrev = list; | |
| 60 | 60 | ||
0 commit comments