Commit 5c05326
deps: V8: backport 6a0a25abaed3
Original commit message:
[riscv] Fix sp handling in MacroAssembler::LeaveFrame
Keep sp <= fp to ensure that data right above fp doesn't get clobbered
by an inopportune signal and its handler.
Such clobbering can happen in e.g. Node.js when JIT-compiled code is
interrupted by a SIGCHLD handler.
Bug: None
Change-Id: Ief0836032ada7942e89f081f7605f61632c4d414
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/7540554
Reviewed-by: Ji Qiu <qiuji@iscas.ac.cn>
Commit-Queue: Yahan Lu (LuYahan) <yahan@iscas.ac.cn>
Reviewed-by: Rezvan Mahdavi Hezaveh <rezvan@chromium.org>
Cr-Commit-Position: refs/heads/main@{#105069}
Refs: v8/v8@6a0a25a
Co-authored-by: kxxt <rsworktech@outlook.com>
PR-URL: #61687
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <richard.lau@ibm.com>1 parent 83b9f8e commit 5c05326
3 files changed
Lines changed: 4 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -36,7 +36,7 @@ | |||
| 36 | 36 | ||
| 37 | 37 | # Reset this number to 0 on major V8 upgrades. | |
| 38 | 38 | # Increment by one for each non-official patch applied to deps/v8. | |
| 39 | - 'v8_embedder_string': '-node.33', | ||
| 39 | + 'v8_embedder_string': '-node.34', | ||
| 40 | 40 | ||
| 41 | 41 | ##### V8 defaults for Node.js ##### | |
| 42 | 42 | ||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -264,6 +264,7 @@ Vadim Gorbachev <bmsdave@gmail.com> | |||
| 264 | 264 | Varun Varada <varuncvarada@gmail.com> | |
| 265 | 265 | Victor Costan <costan@gmail.com> | |
| 266 | 266 | Victor Polevoy <fx@thefx.co> | |
| 267 | + Vivian Wang <wangruikang@iscas.ac.cn> | ||
| 267 | 268 | Vlad Burlik <vladbph@gmail.com> | |
| 268 | 269 | Vladimir Krivosheev <develar@gmail.com> | |
| 269 | 270 | Vladimir Shutoff <vovan@shutoff.ru> | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -5530,9 +5530,10 @@ void MacroAssembler::EnterFrame(StackFrame::Type type) { | |||
| 5530 | 5530 | ||
| 5531 | 5531 | void MacroAssembler::LeaveFrame(StackFrame::Type type) { | |
| 5532 | 5532 | ASM_CODE_COMMENT(this); | |
| 5533 | - addi(sp, fp, 2 * kSystemPointerSize); | ||
| 5533 | + Move(sp, fp); | ||
| 5534 | 5534 | LoadWord(ra, MemOperand(fp, 1 * kSystemPointerSize)); | |
| 5535 | 5535 | LoadWord(fp, MemOperand(fp, 0 * kSystemPointerSize)); | |
| 5536 | + AddWord(sp, sp, 2 * kSystemPointerSize); | ||
| 5536 | 5537 | } | |
| 5537 | 5538 | ||
| 5538 | 5539 | void MacroAssembler::EnterExitFrame(int stack_space, | |
0 commit comments